1241885 - Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task, P5)

Description

[:Gijs (he/him)]

... so that we can remove the draggable toolbar bindings entirely.

Comment 1

[Tim Nguyen :ntim]

I started looking into this, and it looks like bug 1417847 started adding support for this.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1241885 - Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=stransky,bzbarsky,dao

Comment 3

[Tim Nguyen :ntim]

I'm close to having a working patch.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

I can review the widget/gtk part if Karl can't do that.

Comment 6

[Tim Nguyen :ntim]

(In reply to Martin Stránský [:stransky] from comment #5)
> I can review the widget/gtk part if Karl can't do that.

Whatever works for you and Karl, I just need a review of the GTK part :)

Comment 7

[Karl Tomlinson (:karlt)]

IIUC the history here is that toolbar-drag and/or WindowDraggingUtils existed first. -moz-window-dragging was added for https://bugzilla.mozilla.org/show_bug.cgi?id=944836 so that MacOS could perform the dragging without involvement of the app. NT support was added for bug 1163113 for B2G, but not used in real products until https://bugzilla.mozilla.org/show_bug.cgi?id=1219215#c4 . The reasons are not all clear to me, but efficiency of hit testing for frequent NT messages is the reason indicated in https://bugzilla.mozilla.org/show_bug.cgi?id=1107779#c7

I don't know that GTK code can have the same benefits as MacOS and doing hit-testing in the widget code feels a bit awkward to me, but doing things the same way on all platforms seems a good reason to do this.

Comment 8

[Tim Nguyen :ntim]

(In reply to Karl Tomlinson (:karlt) from comment #7)

IIUC the history here is that toolbar-drag and/or WindowDraggingUtils existed first. -moz-window-dragging was added for https://bugzilla.mozilla.org/show_bug.cgi?id=944836 so that MacOS could perform the dragging without involvement of the app. NT support was added for bug 1163113 for B2G, but not used in real products until https://bugzilla.mozilla.org/show_bug.cgi?id=1219215#c4 . The reasons are not all clear to me, but efficiency of hit testing for frequent NT messages is the reason indicated in https://bugzilla.mozilla.org/show_bug.cgi?id=1107779#c7

I don't know that GTK code can have the same benefits as MacOS and doing hit-testing in the widget code feels a bit awkward to me, but doing things the same way on all platforms seems a good reason to do this.

In addition to being consistent across platforms, we want to get rid of XBL here too, which is the major benefit of doing this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176be7000d33
Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=dao,bzbarsky,stransky

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0771389994bb
Backed out 1 changesets for build bustages on a CLOSED TREE

Comment 11

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=176be7000d331cd31aa97a6d8a35bdf0777b520f&selectedJob=222758833

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222758833&repo=autoland&lineNumber=44694

Backout: https://hg.mozilla.org/integration/autoland/rev/0771389994bb84e406bb1f335903c7c5c98d78e5

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5433228bc018
Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding. r=dao,bzbarsky,stransky

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5433228bc018