Closed Bug 1522738 Opened 6 years ago Closed 6 years ago

Fix miscellaneous BigInt warnings and errors

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: terpri, Assigned: terpri)

References

Details

Attachments

(1 file)

clangs reports several warnings in BigInt code, and one platform-dependent error from a variable name typo:

[task 2019-01-24T19:54:12.049Z] 19:54:12    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:1182:13: error: bad implicit conversion constructor for 'RadixInfo'
[task 2019-01-24T19:54:12.049Z] 19:54:12     INFO -    constexpr RadixInfo(uint8_t radix)

[task 2019-01-24T21:33:05.487Z] 21:33:05     INFO -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp: In static member function 'static JS::BigInt* JS::BigInt::createFromInt64(JSContext*, int64_t)':
[task 2019-01-24T21:33:05.488Z] 21:33:05    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:1587:37: error: suggest parentheses around comparison in operand of '==' [-Werror=parentheses]
[task 2019-01-24T21:33:05.489Z] 21:33:05     INFO -     MOZ_ASSERT(res->isNegative() == n < 0);

[task 2019-01-24T23:06:11.602Z] 23:06:11    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:2185:26: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
[task 2019-01-24T23:06:11.602Z] 23:06:11     INFO -      digit |= x->digit(1) << 32;

[task 2019-01-24T21:37:16.260Z] 21:37:16    ERROR -  /builds/worker/workspace/build/src/js/src/vm/BigIntType.cpp:325:16: error: use of undeclared identifier 'HalfDigitBase'; did you mean 'halfDigitBase'?
[task 2019-01-24T21:37:16.260Z] 21:37:16     INFO -    while (q1 >= HalfDigitBase || q1 * vn0 > rhat * HalfDigitBase + un1) {

This is a followup to bug 1502797.

Keywords: checkin-needed
Blocks: js-bigint
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee: nobody → robin
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: