Land Firefox Monitor system add-on into mozilla-central

RESOLVED FIXED in Firefox 67

Status

()

RESOLVED FIXED
a month ago
15 days ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

(Depends on: 6 bugs)

67 Branch
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
Attachment #9041707 - Attachment is obsolete: true
Attachment #9041706 - Attachment is obsolete: true
Attachment #9041706 - Attachment is obsolete: false
Attachment #9041707 - Attachment is obsolete: false
(Assignee)

Comment 4

a month ago

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Try push link to look at later: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ee01baf8e198898e31ff566ea45f39c40c5ffd0

Packaging is failing due to the strings.properties files being identical for two en-* locales. I'm currently thinking about what the best way to fix this is.

(Assignee)

Comment 5

a month ago

(In reply to Nihanth Subramanya [:nhnt11] from comment #4)

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Try push link to look at later: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ee01baf8e198898e31ff566ea45f39c40c5ffd0

Packaging is failing due to the strings.properties files being identical for two en-* locales. I'm currently thinking about what the best way to fix this is.

The script that checks for dupes ignores l10n files, but detects them by checking the path for "/locale/" - this addon was using "/locales/". I've changed that and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db4ee5561e9211c6901702f377de989fb7eed749

Attachment #9041958 - Attachment is obsolete: true
Attachment #9041707 - Attachment is obsolete: true
Attachment #9041706 - Attachment is obsolete: true
(Assignee)

Comment 8

a month ago

Addressed review comments over in the land of Github. Also removed all locales except en-US, since those files will be removed anyway when we migrate translations. Also disabled Telemetry for now till we get data review.

All changes can be viewed in this PR: https://github.com/mozilla/blurts-addon/pull/143

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac448455f1a3418ffe2da6794ff01b24c920d9ef

(Assignee)

Updated

a month ago
Depends on: 1525976
(Assignee)

Updated

a month ago
Depends on: 1525977
(Assignee)

Updated

a month ago
Keywords: checkin-needed

Comment 9

a month ago

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/264d828518f2
Land Firefox Monitor system add-on into browser/extensions. r=johannh

Keywords: checkin-needed

Comment 10

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Updated

a month ago
Depends on: 1527635
(Assignee)

Updated

a month ago
Depends on: 1528947
(Assignee)

Updated

a month ago
Depends on: 1528978
(Assignee)

Updated

a month ago
Depends on: 1529001

Updated

22 days ago
Depends on: 1531274
(Assignee)

Updated

21 days ago
Depends on: 1531838
You need to log in before you can comment on or make changes to this bug.