1525519 - Land Firefox Monitor system add-on into mozilla-central

Status: RESOLVED FIXED

(Firefox :: Firefox Monitor, enhancement)

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1525519 - Land Firefox Monitor system add-on into browser/extensions. r=johannh

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1525519 - Fix eslint issues after initial import of the addon. r=johannh

Depends on D18802

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Try push link to look at later: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ee01baf8e198898e31ff566ea45f39c40c5ffd0

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Try push link to look at later: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ee01baf8e198898e31ff566ea45f39c40c5ffd0

Packaging is failing due to the strings.properties files being identical for two en-* locales. I'm currently thinking about what the best way to fix this is.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #4)

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Try push link to look at later: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ee01baf8e198898e31ff566ea45f39c40c5ffd0

Packaging is failing due to the strings.properties files being identical for two en-* locales. I'm currently thinking about what the best way to fix this is.

The script that checks for dupes ignores l10n files, but detects them by checking the path for "/locale/" - this addon was using "/locales/". I've changed that and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db4ee5561e9211c6901702f377de989fb7eed749

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1525519 - Rename locales/ folder to locale/ for consistency with m-c pattern. r=johannh

Depends on D18803

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1525519 - Land Firefox Monitor system add-on into browser/extensions. r=johannh

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Addressed review comments over in the land of Github. Also removed all locales except en-US, since those files will be removed anyway when we migrate translations. Also disabled Telemetry for now till we get data review.

All changes can be viewed in this PR: https://github.com/mozilla/blurts-addon/pull/143

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac448455f1a3418ffe2da6794ff01b24c920d9ef

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/264d828518f2
Land Firefox Monitor system add-on into browser/extensions. r=johannh

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/264d828518f2