Closed Bug 1525959 Opened 2 years ago Closed 1 year ago

Green up mochitest under GeckoView

Categories

(GeckoView :: General, enhancement, P1)

Unspecified
All
enhancement

Tracking

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(3 files)

There are a handful of failing tests remaining, we should just skip these in order to get things running.

There are few things that are either Fennec-specific or don't work
currently under GeckoView w/ e10s under TestRunnerActivity. Disable
these so we can get some testing going in automation.

Depends on D19015

Attachment #9042196 - Attachment description: Bug 1525959 - Skip some mochitests tests under GeckoView r?#geckoview-reviewers → Bug 1525959 - Skip some mochitests under GeckoView r?#geckoview-reviewers
Attachment #9042196 - Attachment description: Bug 1525959 - Skip some mochitests under GeckoView r?#geckoview-reviewers → Bug 1525959 - Skip some mochitests tests under GeckoView r?#geckoview-reviewers
Assignee: nobody → snorp
Priority: -- → P1
Attachment #9042195 - Attachment description: Bug 1525959 - Run GeckoView mochitests on x86_64 emulators in automatio r=gbrown → Bug 1525959 - Run GeckoView mochitests on x86_64 emulators in automation r=gbrown
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33ea61c54aea
Run GeckoView mochitests on x86_64 emulators in automation r=gbrown
https://hg.mozilla.org/integration/autoland/rev/503cbc86e442
Skip some mochitests tests under GeckoView r=geckoview-reviewers,esawin

The tier 1 failures were crashtests? Those should be unrelated to this bug and were resolved by backout of bug 1522324.

We expect frequent tier 2 failures. Is it OK to re-land with tier 2 failures?

Flags: needinfo?(apavel)

(In reply to Geoff Brown [:gbrown] from comment #5)

The tier 1 failures were crashtests? Those should be unrelated to this bug and were resolved by backout of bug 1522324.

We expect frequent tier 2 failures. Is it OK to re-land with tier 2 failures?

Ah, I wasn't sure what was going on with the crashtest -- there were permafails on debug mochitest, though, which I'm working on now.

Flags: needinfo?(snorp)

(In reply to Geoff Brown [:gbrown] (away Feb 18, 19) from comment #5)

The tier 1 failures were crashtests? Those should be unrelated to this bug and were resolved by backout of bug 1522324.

We expect frequent tier 2 failures. Is it OK to re-land with tier 2 failures?

Sorry for the lat reply, I've been on PTO. No, tier1 were opt-mochitest-24 failures.

Also, normally for tier2 we don't backout unless they are very frequent (every push) and the developer does not reply.

This should give a better view.

Flags: needinfo?(apavel)
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51efc5e08cee
Run GeckoView mochitests on x86_64 emulators in automation r=gbrown
https://hg.mozilla.org/integration/autoland/rev/75e35acd4f0d
Skip some mochitests tests under GeckoView r=geckoview-reviewers,esawin

Oops - https://hg.mozilla.org/integration/autoland/rev/51efc5e08ceeeacb157cfb36a1bc827cbf9a7c8b#l1.15 set only the opt tests as tier 2. /debug is running and failing as tier 1! I think this would be correct:

android-em-7.*: 2

Flags: needinfo?(snorp)
Attachment #9047132 - Attachment description: Bug 1525959 - Only run mochitest-e10s on opt builds r=gbrown → Bug 1525959 - Only run mochitest-e10s on GeckoView opt builds r=gbrown
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e767399d23cc
Only run mochitest-e10s on GeckoView opt builds r=gbrown
See Also: → 1530546
Flags: needinfo?(snorp)
See Also: → 1563277

:snorp, where are bugs to re-enable the disabled tests? I just noticed dom/animation/test/mozilla/test_restyles.html was disabled and filed a new bug for that (bug 1583658), if there is already a bug, please duplicate it.

Thank you!

Flags: needinfo?(snorp)
Blocks: 1583956

There are a few things scattered around. AFAIK there isn't any single bug that rounds all of that up.

Flags: needinfo?(snorp)
You need to log in before you can comment on or make changes to this bug.