Closed Bug 1527934 Opened 8 months ago Closed 8 months ago

QuantumBar: One-off search buttons aren't hidden when an "@engine" search alias is entered

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: adw)

References

Details

Attachments

(1 file)

When entering a search alias, the one-off search buttons are not hidden on QuantumBar.

STR:

  1. Enter "@" in the address bar

Expected Results

=> List of aliases with one-off buttons hidden.

Actual Results

=> List of aliases with one-off buttons displayed.

Note: when we fix this, we should enable assertOneOffButtonsVisible in browser_urlbarSearchFunction.js for QuantumBar and hiddenWhenUsingSearchAlias in browser_urlbarOneOffs.js.

Just updated the previous comment - I'm going to be implementing a better way of checking the visible status in bug 1527940, so adding dependency.

Depends on: 1527940
Priority: -- → P2
Blocks: 1491248, 1524125
Assignee: nobody → adw
Status: NEW → ASSIGNED
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80442991ea37
Hide the one-off search buttons when an "@engine" search alias is entered. r=dao
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.