1530338 - Improve handling of waiting for results once re-using results has been implemented

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, task, P3)

Description

[Mark Banner (:standard8)]

Currently for QuantumBar, we're forced to wait for a search to be fully complete, rather than for just a particular index.

For a lot of tests this doesn't matter, but some tests e.g. browser_ext_omnibox.js, there's some parts that can't be tested properly.

Once bug 1523602, we should revisit UrlbarTestUtils.promiseResultAt, and see if we can improve it.

We also need to re-enable the section in browser_ext_omnibox.js that is being added by bug 1522508.

Comment 1

[Mark Banner (:standard8)]

This will also apply to UrlbarTestUtils.promiseSearchSuggestions as well.

Comment 2

[Dão Gottwald [:dao]]

It's not clear to me how exactly this depends on bug 1523602. Can you elaborate?

Comment 3

[Mark Banner (:standard8)]

For tests against the old address bar, we'd sometimes wait on the individual result to be displayed rather than the whole search to be complete:

https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/browser/components/urlbar/tests/UrlbarTestUtils.jsm#373-385

This was possible, due to the results re-use. Results would have the search string noted in the element, so we could watch for when they changed to the new search string.

For the QuantumBar case we wanted to do something similar, but we didn't have the re-use happening, so it didn't make sense to try and fit it in at the time, and hence the dependency.

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Hi, I'm closing this bug as WFM since I think this bug is no longer valid. If I'm wrong, please do reopen it.