1530881 - Printing PDFs with CFF fonts is broken on MacOS

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Brendan Dahl [:bdahl]]

For steps to reproduce see: https://bugzilla.mozilla.org/show_bug.cgi?id=1523991

Comment 1

[Brendan Dahl [:bdahl]]

This is more fallout from bug 1489996 and moving the glyphs to the private use area. I have a patch in progress at https://github.com/mozilla/pdf.js/pull/10591

Comment 2

[Brendan Dahl [:bdahl]]

Fixed by bug Bug 1532355 and bug 1531801.

Comment 3

[Brendan Dahl [:bdahl]]

Attachment: Uplift CFF font fixes for MacOS. r=yury

Includes pdf.js pull requests:
https://github.com/mozilla/pdf.js/pull/10591
https://github.com/mozilla/pdf.js/pull/10604

Comment 4

[Brendan Dahl [:bdahl]]

Attachment: Bug 1530881 - Uplift CFF font fixes for MacOS. r=yury

Includes pdf.js pull requests:
https://github.com/mozilla/pdf.js/pull/10591
https://github.com/mozilla/pdf.js/pull/10604

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 9048576 [details]
Bug 1530881 - Uplift CFF font fixes for MacOS. r=yury

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1489996
• User impact if declined: PDF's using CFF fonts will not print correctly on MacOS. Again, tax season and would be good to fix sooner rather than later.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On MacOS:

1. Load https://instantpot.com/wp-content/uploads/2018/08/12PSI-EPC-Cooking-Time-Tables-English.pdf
2. Open print dialog
3. Print to PDF file
4. Open PDF file in MacOS Preview
   Output should look like displayed PDF not like https://bugzilla.mozilla.org/attachment.cgi?id=9040146

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The path the new code follows is well tested for displaying PDFs. For printing, the fonts are completely broken, so it can't get much worse than that.
• String changes made/needed:

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I successfully reproduced the issue on Firefox Nightly 67.0a1 (2019-02-26) under macOS 10.12 using the STR from Comment 5.

The issue is fixed on latest Nightly 67.0a1 (2019-03-06) under macOS 10.12.

I will verify it on beta too as soon as it will be pushed.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9048576 [details]
Bug 1530881 - Uplift CFF font fixes for MacOS. r=yury

Fix for recent regression, verified in Nightly.
OK for uplift for beta 14.

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/86214b1c530d

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The issue is fixed on Firefox Beta 66.0b14 (20190307095232), build taken from treeherder. The test was performed on macOS 10.12.