153104 - All ISO 3166 country codes should be in regionNames.properties

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Tjibbe Steneker]

Many country codes are not present in the file regionNames.properties at the
moment. Because of this, the spellchecker does not always show the right
language name. It might also cause other problems I have not found yet.

Workaround: (for use with the spellchecker)
For countries not listed in the file regionNames.properties, remove the "-" and
the country code from the filename.

Comment 1

[Rui Xu]

Code issue? QA to yokoyama for now.

Comment 2

[Frank Tang]

estimate work  1 day.

Comment 3

[Frank Tang]

assign

Comment 4

[Paul Oranje]

This problem exists for any product that ships the regionNames.properties file,
among them MailNews and Thunderbird.

Comment 5

[Marcel Gosselin]

Attachment: regionNames.properties up-to-date with ISO3166

I parsed the current version of the text file containing the ISO 3166 codes
given on 
http://www.iso.org/iso/en/prods-services/iso3166ma/02iso-3166-code-lists/index.html

to make the current patch.

Comment 6

[Marcel Gosselin]

About the patch 135394, 
since all names and codes where in capital letters in the text file I parsed to
give this, I modified them so that the first letter of every word be 
capitalized. I'm not a native English speaker be specially careful in looking at
every country name which has more than one word, sometimes the capital letter 
doesn't seem right to me (as on And word).

A few names have changed and I don't know which one should be preferred. Those are:
ae = U.A.E.                -> United Arab Emirates
ly = Libya                 -> Libyan Arab Jamahiriya
sy = Syria                 -> Syrian Arab Republic
tt = Trinidad              -> Trinidad And Tobago
mo = Moldavia              -> Macao (a completely different country but this one
is in the standard...)
tw = Taiwan                -> Taiwan, Province Of China
mk = Macedonia, F.Y.R. of  -> Macedonia, The Former Yugoslav Republic Of
kp = North Korea           -> Korea, Democratic People's Republic Of
kr = South Korea           -> Korea, Republic Of

Also look at 
ci = Cote D'ivoire
I thought in English it was Ivory Coast but I might be mistaken. If it is still
Cote d'Ivoire tell me how to write it, like in French as I just written it 
(notice the capital letters).

Comment 7

[Marcel Gosselin]

Comment on attachment 135394 [details] [diff] [review]
regionNames.properties up-to-date with ISO3166

Requesting review (Please look the comment#6)

Comment 8

[Jungshik Shin]

I don't think it's always a good idea to use ISO 3166 names. This is a part of
the UI and using names familar and likely to be known to as many people as
possible is more important. 

Comment 9

[Dan Kenigsberg]

I hope attachment 135394 [details] [diff] [review] is applied soon, since Israel (and many other
countries) are missing from the current regionNames.properties file.

Without it, when you load the Hebrew spelling dictionary it appears as "he-IL"
(its filename) instead of Hebrew/Israel as it should.

Note, that Hebrew already appears in languageNames.properties.

Comment 10

[Frank Tang]

what a hack. I have not touch mozilla code for 2 years. I didn't read these bugs
for 2 years. And they are still there. Just close them as won't fix to clean up.

Comment 11

[Malcolm Rowe]

ftang: This is a bug with a patch requesting review. Just because you don't want
to fix it, doesn't mean this isn't a valid bug. Reopening.

(or were you suggesting that this shouldn't be fixed?)

Comment 12

[Yung-Fong Tang]

(In reply to comment #11)
> ftang: This is a bug with a patch requesting review. Just because you don't want
> to fix it, doesn't mean this isn't a valid bug. Reopening.
> 
> (or were you suggesting that this shouldn't be fixed?)

patch? There were no patch here. A patch of an old file is a cvs diff -u. A
whole file is not considering a patch. 
I never resolve this as an invalid bug. I only resolve it as a wontfix bug. 

>Without it, when you load the Hebrew spelling dictionary it appears as "he-IL"
>(its filename) instead of Hebrew/Israel as it should.

Why the Hebrew Spelling Dictionary use 'he-IL' instead of 'he' only. Do you have
any different Heberw dictionary other than 'Israel Hebrew'? If not, then the
problem is a wrong usage of region code in spell checker and you should file a
bug against the spell checker for the locale name there instead. 

Comment 13

[Dan Kenigsberg]

Yung-Fong Tang, you have a valid point here. Maybe I SHOULD rename the Hebrew
dictionary filename to he.dic.

This, however, does not change the fact that Israel and the rest of the
countries in the world should probably appear in regionNames.properties.

Comment 14

[Jo Hermans]

*** Bug 292045 has been marked as a duplicate of this bug. ***

Comment 15

[:Gavin Sharp [email: [e-mail]]]

*** Bug 347889 has been marked as a duplicate of this bug. ***

Comment 16

[Simon Montagu :smontagu]

Attachment: Add all missing region names

As well as bringing the files up-to-date with ISO-3166 I also sorted the list, so this patch is very unclear. I'll attach some more informative diffs immediately.

Comment 17

[Simon Montagu :smontagu]

Attachment: New regionnames.properties diffed against sorted version of old file

This attachment shows more clearly the additions to the file and a few name changes.

Comment 18

[Simon Montagu :smontagu]

Attachment: Names changed from ISO-3166

This is a diff of the new file against the official ISO-3166 file, converted to the same format and order, to show which names are different from the official ones. Following comment 8, I've tried to use the most simple and familiar forms of the names, on the following principles:

I omit descriptive terms like "Republic of", "Federated States of", etc. Where this leaves an ambiguity I use forms commonly used in English: North Korea/South Korea (these were already in the file) and Congo-Brazzaville/Congo-Kinshasa. Exception: "Macedonia, F.Y.R. of" which I won't change from the current form until the international controversies concerning it are resolved (see bug 230866)

Where the official list uses a form like "Virgin Islands, U.S." which are appropriate for alphabetical lists I reverse it to "U.S. Virgin Islands" to be more readable.

I use English names instead of local names for "Ivory Coast" and "Vietnam".

Where the current file uses initials instead of the full name, I retain the initials.

Comment 19

[Jungshik Shin]

Comment on attachment 235633 [details] [diff] [review]
Add all missing region names

r=jshin

Comment 20

[Simon Montagu :smontagu]

Checked in

Comment 21

[Jo Hermans]

If the list of country names is also used for spelling checks, maybe we should consider to take this in Firefox 2.0 too (not b2, it's too late).

This is the list of country names that are in this country-list, but not in the dictionary :
Burkina Faso
Darussalam (in Brunei Darussalam)
Bouvet (in Bouvet Island)
Malvinas (in Falkland Islands)
Faroe (in Faroe Islands)
Kitts (in Saint Kitts and Nevis)
Sri Lanka
Niue
Papua (in Papua New Guinea)
Miquelon (in Saint Pierre and Miquelon)
Palau
Mayen (in Svalbard and Jan Mayen)
Sao (in Sao Tome and Principe)
Caicos (Turks and Caicos Islands)
Tokelau
Timor-Leste
Futuna (in Wallis and Futuna)
Mayotte

Most of these will not be used much in emails and form-fields, but "Sri Lanka", "Papua" and "Burkina Faso" might occur more often. I saw them first 2 in my personal email from customers, that's how I got thinking about this.

Note that I'm not asking for a blocking flag. If it's only a data-file update, it should be safe.

Comment 22

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #21)
> If the list of country names is also used for spelling checks, maybe we should
> consider to take this in Firefox 2.0 too (not b2, it's too late).

That would add lots of new strings for localization and we are in l10n-freeze now...

Comment 23

[Damjan Georgievski]

(In reply to comment #18)
> Exception: "Macedonia, F.Y.R. of" which I won't change from the current form 
> until the international controversies concerning it are resolved (see bug 230866)

So how did you choose "F.Y.R. of" ?!? It's not according to the ISO standard.
If you want to be politically correct use the temporary agreed name of:
Macedonia, the Former Yugoslav Republic of
(note the capitalization).

I still think it's offensive .. but it seems nobody cares about it.