Support light and dark subpixel text masks in Skia on mac

RESOLVED FIXED in Firefox 66

Status

()

Product:
Core
Component:
Graphics
Type:
enhancement
Status:
RESOLVED FIXED
Opened:
5 months ago
Updated:
4 months ago

People

(Reporter: lsalzman, Assigned: lsalzman)

Tracking

({feature})

Version:
unspecified
Target:
mozilla67
Platform:
Unspecified
macOS
Points:
---
Dependency tree / graph
Duplicates:
1524250

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 fixed, firefox67 fixed)

Details

Attachments

(1 attachment)

Bug 1531867 - support light and dark subpixel AA masks in Skia on mac
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-beta+
Details | Review
No description provided.
Duplicate of this bug: 1524250

We might want to uplift to 66 Beta, but we don't need to uplift to 65 Release. 66 Beta will ride to the Release channel in less than three weeks (2019-03-19).

Blocks: 1495282
status-firefox65: --- → wontfix
status-firefox66: --- → affected
status-firefox67: --- → affected
status-firefox-esr60: --- → wontfix
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/571c5aa04580
support light and dark subpixel AA masks in Skia on mac. r=mstange

https://hg.mozilla.org/mozilla-central/rev/571c5aa04580

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment on attachment 9047809 [details]
Bug 1531867 - support light and dark subpixel AA masks in Skia on mac

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1495282
  • User impact if declined: macOS mojave users will see fonts with weights significantly differing from safari under some text colors.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Matches up with appearance of both Safari andWebRender macOS font implementation.
  • String changes made/needed:
Attachment #9047809 - Flags: approval-mozilla-beta?
Depends on: 1532171

The fix from bug 1532171 will need to be uplifted as well. The fix in this bug is otherwise fine, it is just that the user had disabled font smoothing at the OS level, which threw a wrench in the fix. Bug 1532171 resolves that.

Comment on attachment 9047809 [details]
Bug 1531867 - support light and dark subpixel AA masks in Skia on mac

Low risk fix for fonts with dark background. OK for beta 14 uplift.

Attachment #9047809 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
See Also: → 1541129
You need to log in before you can comment on or make changes to this bug.