1531867 - Support light and dark subpixel text masks in Skia on mac

Status: RESOLVED FIXED

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1531867 - support light and dark subpixel AA masks in Skia on mac

Comment 3

[Chris Peterson [:cpeterson]]

We might want to uplift to 66 Beta, but we don't need to uplift to 65 Release. 66 Beta will ride to the Release channel in less than three weeks (2019-03-19).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/571c5aa04580
support light and dark subpixel AA masks in Skia on mac. r=mstange

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/571c5aa04580

Comment 6

[Lee Salzman [:lsalzman]]

Comment on attachment 9047809 [details]
Bug 1531867 - support light and dark subpixel AA masks in Skia on mac

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1495282
• User impact if declined: macOS mojave users will see fonts with weights significantly differing from safari under some text colors.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Matches up with appearance of both Safari andWebRender macOS font implementation.
• String changes made/needed:

Comment 7

[Lee Salzman [:lsalzman]]

The fix from bug 1532171 will need to be uplifted as well. The fix in this bug is otherwise fine, it is just that the user had disabled font smoothing at the OS level, which threw a wrench in the fix. Bug 1532171 resolves that.

Comment 8

[Liz Henry (:lizzard) (use needinfo)]

Comment on attachment 9047809 [details]
Bug 1531867 - support light and dark subpixel AA masks in Skia on mac

Low risk fix for fonts with dark background. OK for beta 14 uplift.

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9b08cd8e3058