1533708 - Restart Firefox broken in Nightly

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]
Starting with 03.07 nightly builds, restarting the browser using the known methods fails.

[Environment:]
Windows10 Pro
(Not affected) Ubuntu 16.04
(Not affected) Mac 10.14

[Steps:]

1. Start Nightly. (03.07 build)
2. Go about:profiles and select "Restart normally"
   2'. Go about:profiles and select "Restart with addons disabled".
   2". Press Ctrl+Shift+J and then Ctrl+Alt+R

[Actual Result:]
2./2'/2" Browser is shutdown and

[Expected Result:]
2. Browser is restarted normally.
2'. Browser is restarted with addons disabled.
2". Browser is restart normally + browser console opened.

[Regression Range:]
Mozregression could only : Narrowed inbound regression window from [ecbfad74, af29567e] (4 builds) to [ca64604d, af29567e] (2 builds) (~1 steps left), after which the inbound could not

Seems a bit unlikely, but it is possible that this regression was introduced by bug 1528252. Please remove the blocking if that's not what regressed the restart behavior.

Comment 1

[Rares Doghi, Desktop QA]

Also it seems that if you download and unzip the archive and start the Firefox Browser from RUN with the -no-remote command the Firefox browser can be restarted without issues.

Comment 2

[Adrian Florinescu [:aflorinescu]]

(In reply to Rares Doghi from comment #1)

Also it seems that if you download and unzip the archive and start the Firefox Browser from RUN with the -no-remote command the Firefox browser can be restarted without issues.

So, probably the bug 1518639 is more likely than bug 1528252 to be a possible regressing factor for this bug.

Comment 3

[Jim Mathies [:jimm]]

My guess would be the DDE removal work in bug 513742.

Comment 4

[Dave Townsend [:mossop]]

This is largely from bug 1518639.

What's happening is an error in the code is causing us to not shutdown the remote service before launching the new Firefox, so it probably attempts to remote to the process that is in the middle of quitting. Additionally telling the remote service to shutdown on windows isn't actually shutting it down.

Patch incoming.

Comment 5

[Dave Townsend [:mossop]]

Attachment: Bug 1533708: Properly shut down the remote service before launching Firefox again. r=jmathies

The main changes here are to stop checking if we're shutting down when we
already know we are shutting down and making sure the windows remote server
shuts down properly.

I also spotted that nsINativeAppSupport.quit is now unused so I removed it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdd61e6fb911
Properly shut down the remote service before launching Firefox again. r=jmathies

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fdd61e6fb911

Comment 8

[Ajay Gupta]

Thanks for the fix. Latest Nightly is behaving normally now.

Comment 9

[ovidiu boca[:Ovidiu]]

I verified this on Windows 10 and 7 with FF Nightly 67.0a1(2019-03-12) and I can confirm the fix.