1535757 - Form passwords are no longer imported from Internet Explorer on Windows 7

Status: RESOLVED WONTFIX

(Firefox :: Migration, defect, P2)

Description

[Matthew N. [:MattN]]

Logins aren't imported from IE on Windows 7 and an error appears in the Browser Console:

Error stack

TypeError: "can't convert the number 65533 to element 40 of the type ctypes.unsigned_char.array(84)"
    _extractDetails resource:///modules/IEProfileMigrator.jsm:273
    _migrateURIs resource:///modules/IEProfileMigrator.jsm:186
    migrate resource:///modules/IEProfileMigrator.jsm:129
    doMigrate resource:///modules/MigrationUtils.jsm:347
    MP_migrate resource:///modules/MigrationUtils.jsm:395
    onMigratingMigrate chrome://browser/content/migration/migration.js:307
    onMigratingPageShow chrome://browser/content/migration/migration.js:303
    MU_showMigrationWizard resource:///modules/MigrationUtils.jsm:892
    oncommand chrome://browser/content/browser.xul:1

https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/browser/components/migration/IEProfileMigrator.jsm#273

Note: Windows 8+ uses different password storage and encryption so is unrelated to this bug.

Bug 1484496 broke history import from IE which then breaks IE login import from Windows 7 since it relies on hashes of URLs from the history to extract logins. Separately there were changes to fix the Windows decryption for Chrome (shared by IE and Chrome migrators) in bug 1520949. Due to multiple compounding issues (not reported until much after the issues landed due to QA seemingly not testing these migrators), I'm not sure if bug 1520949, bug 1520949, or something else is the cause of this breakage.

Jared, do you want to try take a look at this since you're now most familiar with the decryption code? You can probably backout bug 1520949 to see if it caused this regression.

Comment 1

[Pascal Chevrel (relman team) -> :pascalc]

Marking as fix-optional for 67 as this is a P2 bug with no owner. If this gets fixed and a safe patch is upliftable, we can evaluate it.

Comment 2

[Liz Henry (:lizzard)]

Fix optional a final time now to remove this from weekly triage.

Comment 5

[Matthew N. [:MattN]]

We should maybe consider this bug fix in the coming months.

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Mat, should we de-prioritize this bug to P3? Thanks

Comment 8

[Matthew N. [:MattN]]

From the last 30 days of telemetry IE7 password import is:

• the 5/6th most popular data type + OS version combo (tied with the new Edge on Windows 10): https://sql.telemetry.mozilla.org/queries/70428#177352
• accounts for 3.7% of all password import https://sql.telemetry.mozilla.org/queries/70428#177357 (about the same as importing from the new Edge on Win10)

It's possible that these users are more likely to stay with Firefox and our password manager than bug 1303176 because of different expectations.

Comment 9

[Rachel Tublitz [:rachel]]

S1 or S2 bugs need an assignee - could you find someone for this bug?

Comment 10

[Jens Stutte [:jstutte]]

Do we have data, how many people are migrating from IE to FF on Windows 7 these days? This smells like a WONTFIX in the long run.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

The updated data says that 1.47% of password import attempts are made with IE on Windows 7, and that it is now 8th on the list (down from 5/6th on the list and 3.7% in April 2020). This is a decrease of about 60% in just 7 months.

I haven't had time to work on this and I don't expect I will have time in the near future so I'll clear the needinfo. I'm not sure I would call this wontfix just yet but it is leading in that direction.

Comment 12

[Gregory Pappas [:gregp]]

Windows 7 is no longer supported and the IE7FormPasswords migrator was removed in bug 1846934