Closed Bug 1540253 Opened 8 months ago Closed 6 months ago

Define a property for an extension's recommended status

Categories

(Toolkit :: Add-ons Manager, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: ddurst, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [feature-scope])

Attachments

(1 file)

If we're going to show which extensions are recommended in about:addons, we need to be able to tell which ones are recommended.

Priority: -- → P2
Mentor: aswan
Depends on: 1554317
No longer depends on: 1554317

This bug is for defining a property on the AddonWrapper. Something like:

let addon = await AddonManager.getAddonByID("recommended@addon");
addon.recommended === true;
Summary: Identify extensions as recommended when they're installed → Define a property for an extension's recommended status

Hi, I'd like to take this up if no one else is working on this. Can you give me any more details that'd help me while working on this? Thanks.

(In reply to Rithvik Patibandla[:rithvikp] from comment #2)

Hi, I'd like to take this up if no one else is working on this. Can you give me any more details that'd help me while working on this? Thanks.

Hi, Rithvikp, in setting a mentor I didn't mean to imply this is a good bug for a contributor -- I just wanted to note who the best person was to help someone new to this part of the code. However, this should probably be done internally. Sorry for causing confusion!

Mentor: aswan
Assignee: nobody → rob
Status: NEW → ASSIGNED
Attachment #9071510 - Attachment description: Bug 1540253 - Define an isRecommended property for add-ons r?rpl r?robwu → Bug 1540253 - Define an isRecommended property for add-ons
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b8409408524
Define an isRecommended property for add-ons r=aswan
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Regressions: 1559112
Regressions: 1559131

Please request beta uplift when you get a chance.

Flags: needinfo?(rob)

Comment on attachment 9071510 [details]
Bug 1540253 - Define an isRecommended property for add-ons

Beta/Release Uplift Approval Request

  • User impact if declined: Recommended add-ons installed from AMO will not be shown as recommended in Firefox.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1539699, Bug 1559112, Bug 1559131
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): On Nightly for a few days, warning and test failure fixed, has test coverage.
  • String changes made/needed:
Attachment #9071510 - Flags: approval-mozilla-beta?
Flags: needinfo?(rob)

Comment on attachment 9071510 [details]
Bug 1540253 - Define an isRecommended property for add-ons

approved for 68.0b11

Attachment #9071510 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

As per Comment 8, the “Needs manual testing from QE?” field is set to ‘NO’, however the “qe-verify -” flag is not set for this bug.

As per the above, will this fix require manual validation? If yes, could you please provide steps to reproduce in order to correctly test it and set the "qe-verify+" flag. Thanks!

Flags: needinfo?(rob)
Flags: needinfo?(rob)
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.