1540253 - Define a property for an extension's recommended status

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[David Durst [:ddurst]]

If we're going to show which extensions are recommended in about:addons, we need to be able to tell which ones are recommended.

Comment 1

[Mark Striemer [:mstriemer]]

This bug is for defining a property on the AddonWrapper. Something like:

let addon = await AddonManager.getAddonByID("recommended@addon");
addon.recommended === true;

Comment 2

[Rithvik Patibandla[:rithvikp]]

Hi, I'd like to take this up if no one else is working on this. Can you give me any more details that'd help me while working on this? Thanks.

Comment 3

[David Durst [:ddurst]]

(In reply to Rithvik Patibandla[:rithvikp] from comment #2)

Hi, I'd like to take this up if no one else is working on this. Can you give me any more details that'd help me while working on this? Thanks.

Hi, Rithvikp, in setting a mentor I didn't mean to imply this is a good bug for a contributor -- I just wanted to note who the best person was to help someone new to this part of the code. However, this should probably be done internally. Sorry for causing confusion!

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1540253 - Define an isRecommended property for add-ons

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b8409408524
Define an isRecommended property for add-ons r=aswan

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0b8409408524

Comment 7

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 8

[Mark Striemer [:mstriemer]]

Comment on attachment 9071510 [details]
Bug 1540253 - Define an isRecommended property for add-ons

Beta/Release Uplift Approval Request

• User impact if declined: Recommended add-ons installed from AMO will not be shown as recommended in Firefox.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1539699, Bug 1559112, Bug 1559131
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): On Nightly for a few days, warning and test failure fixed, has test coverage.
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9071510 [details]
Bug 1540253 - Define an isRecommended property for add-ons

approved for 68.0b11

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/51db6334c288

Comment 11

[Alex Cornestean]

Hello,

As per Comment 8, the “Needs manual testing from QE?” field is set to ‘NO’, however the “qe-verify -” flag is not set for this bug.

As per the above, will this fix require manual validation? If yes, could you please provide steps to reproduce in order to correctly test it and set the "qe-verify+" flag. Thanks!