Closed Bug 1541489 Opened 6 months ago Closed 5 months ago

Turn off gfx.webrender.all.qualified before shipping Firefox 67

Categories

(Core :: Graphics: WebRender, task, P1, major)

Other Branch
task

Tracking

()

RESOLVED FIXED
Tracking Status
firefox67 blocking fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1523598 +++

+++ This bug was initially created as a clone of Bug #1510289 +++

+++ This bug was initially created as a clone of Bug #1499088 +++

In bug 1498711 we turned on WebRender without #ifdef guards so that it can ride to late beta.

We do want it to go to release in 67, but we want to do a gradual rollout. So we want gfx.webrender.all.qualified to start out at false, and then we'll use Normandy to gradually change the pref to true. The mechanism for this was added in bug 1503776 by :cpearce.

This means that we want to flip gfx.webrender.all.qualified to false right before 67 goes to release (so that we don't disable it for beta users).

No longer blocks: 1541488
Blocks: 1541488
Type: defect → task
Priority: P2 → P1
Whiteboard: [gfx-noted]

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1498711
  • User impact if declined: All qualified users will get WR enabled on release 67, instead of getting gradually rolled out
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky. We did this in previous releases too. Landing this should be "safe" in that if the Normandy gradual rollout fails for whatever reason we keep the status quo of keeping WR off. It would be riskier to go full throttle to 100% of the qualified population right away.
  • String changes made/needed:
Assignee: nobody → kats
Attachment #9055524 - Flags: approval-mozilla-beta?

^ Above patch should land on 67 just before it goes to release, same as we did in bug 1523598.

Comment on attachment 9055524 [details] [diff] [review]
Turn gfx.webrender.all.qualified to false for initial 67 release

Let's take it into our last beta tomorrow, thanks.
Attachment #9055524 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.