1543099 - Implement Runtime.evaluate

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Once bug 1543098 is done and Runtime.executionContextCreated events are sent, we can start implementing Runtime.evaluate and Runtime.callFunctionOn.

https://chromedevtools.github.io/devtools-protocol/tot/Runtime#method-evaluate
https://chromedevtools.github.io/devtools-protocol/tot/Runtime#method-callFunctionOn

Here, I'm suggesting to implement both in the same bug as they are very similar and both are used by puppeteer to implement Page.evaluate.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1543099 - Implement Runtime.evaluate.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

I'm scoping this down to implement only Runtime.evaluate as it appears that callFunctionOn can easily be implemented in a followup and brings some additional complexity that would be worth reviewing independently.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1543099 - Split browser_runtime_executionContext into multiple functions

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae516950d779a4ab35ed8ffa3eac43abb8aec783

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c074ab51d55
Split browser_runtime_executionContext into multiple functions r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/6c9b27fd6233
Implement Runtime.evaluate. r=remote-protocol-reviewers,ato

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7c074ab51d55
https://hg.mozilla.org/mozilla-central/rev/6c9b27fd6233