1543624 - Windows unit tests are run with very old version of node

Status: RESOLVED WORKSFORME

(Testing :: General, defect, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

While trying to land bug 1540656 I noticed that there were some odd failures of the http2 server on windows.
Running locally it worked just fine, but on try it always failed. Looking through the logs it seems that node was throwing an exception for one of the APIs I was using.

It seems that the node version we have in tooltool is much older than the one used when running locally in .mozbuild/node/node.exe

The one in tooltool is v6.9.1
The one in .mozbuild is v8.11.3

We should make sure these are in sync (for win32 at least, but maybe we should do it for all platforms)

Comment 1

[Mike Hommey [:glandium]]

Tests using node should use the node toolchain artifact rather than what's in tooltool.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

How do we do that?

Comment 3

[Mike Hommey [:glandium]]

You need to add fetches, but at the moment there are some problems doing that. See the dependencies I added. Follow bug 1525218, which is where I'm going to do something similar for minidump_stackwalk once those problems are addressed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:gbrown, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Rok Garbas [:garbas]]

if you need access to upload new version of node to tooltool let me know and i can provide you access or you can also ask me to upload it for you

Comment 6

[Honza Bambas (:mayhemer)]

Junior, as you are working on bug 1556037 right now, would cooperation with Rok on this bug help you?

Comment 7

[Junior [inactive]]

Yes. Thanks Honza.

Hello Rok,
As bug 1556037 Comment 7 said, we want to verify if netwerk/test/unit/test_http2-proxy.js works in treeherder with nodejs v10+
I stole patch in bug 1547823 and I need some help to make it work in treeherder:try.

Could you please help me to move this forward? Thanks.

Comment 8

[Rok Garbas [:garbas]]

Hi :junior,

you provide me with the file(s) you want me to upload to tooltool and in return i will provide you with the manifest(s) that you need to change in-tree. I assume you would want to update node on all of the platforms as it was done initially in Bug 1313099.

I suggest you open a new bug to track uploads to tooltool and ping me there.

Comment 9

[Junior [inactive]]

File bug 1571573 for updating node in tooltool

Comment 10

[Valentin Gosu [:valentin] (he/him)]

I think this was fixed, right?