Fix the height of column rules after enabling column-span
Categories
(Core :: Layout: Columns, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(2 files)
According to the spec Column gaps and rules
The length of the column gaps and column rules is equal to the column height.
However, after fixing bug 1411422, ColumnSetFrame is no long take 100% height of ColumnSetWrapperFrame. As a result, column rules are not equal to the column height in several tests including layout/reftests/columns/min-width-2.html, testing/web-platform/tests/css/css-multicol/multicol-rule-004.xht and layout/reftests/w3c-css/received/css-multicol/multicol-rule-004.xht.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
According to the spec, "A column rule is drawn in the middle of the
column gap with the endpoints at opposing content edges of the multicol
container." https://drafts.csswg.org/css-multicol-1/#column-gaps-and-rules
Therefore, the <div> that simulates column-rules in references should be
100px height.
|
|
Assignee | |
Comment 2•5 years ago
|
||
After enabling column-span, ColumnSet becomes an anonymous child under
ColumnSetWrapperFrame. It doesn't need to handle border and padding,
containment, and non-auto block-size. ColumnSet's final block-size is
simply the union of ::-moz-column-content frames' rects.
However, we should extend ColumnSet's block-size to consume the
available block-size so that the column rules are drawn to the block-end
edge of the multicol container.
Depends on D39059
|
||
Updated•5 years ago
|
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/03a11c109d07 Part 1 - Fix the height of column-rules in multicol-breaking-*-ref.html. r=dbaron https://hg.mozilla.org/integration/autoland/rev/a06a6a6e1c5e Part 2 - Fix the block-size of the column-rule by consuming available block-size. r=dbaron
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18241 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 6•5 years ago
|
||
Backed out 2 changesets (bug 1548100) for causing nsColumnSetFrame.cpp perma asertion failures
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&revision=a06a6a6e1c5e79a6c661d5bd7485f3855afd4112&searchStr=reftest
backout: https://hg.mozilla.org/integration/autoland/rev/a93ed6014a77c15ea8b28dc7835a53be8c79f509
|
|
Assignee | |
Comment 7•5 years ago
|
||
This assertion failure in comment 6 is fixed by bug 1565665. I did land bug 1565665 prior to this bug, but autoland was closed at that time. When autoload reopened, it didn't land them in the correct order ... Anyway, I'll reland this bug once bug 1565665 is 100% stick to m-c.
Upstream PR merged
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bdd367e52610 Part 1 - Fix the height of column-rules in multicol-breaking-*-ref.html. r=dbaron https://hg.mozilla.org/integration/autoland/rev/87d49e3ac012 Part 2 - Fix the block-size of the column-rule by consuming available block-size. r=dbaron
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bdd367e52610
https://hg.mozilla.org/mozilla-central/rev/87d49e3ac012
Description
•