1548383 - [about:addons] Support extensions.getAddons.showPane pref to disable HTML-based discopane

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Rob Wu [:robwu]]

Bug 1546248 introduces a new HTML-based discopane in the about:addons page, but doesn't respect the extensions.getAddons.showPane preference.

Before enabling the HTML-based discopane by default, we should support the pref again, to allow users to completely disable the discopane. This logic should also be there if about:addons completely switches from XUL to HTML (bug 1525179).

Relevant snippets:

• https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/toolkit/mozapps/extensions/content/extensions.js#2132-2136
• https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/toolkit/mozapps/extensions/content/extensions.js#1027-1034

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1548383 - Support extensions.getAddons.showPane in HTML discopane

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5724b63be8ac
Support extensions.getAddons.showPane in HTML discopane r=aswan

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5724b63be8ac

Comment 4

[CosminB]

Attachment: Bug1548383.gif

This issue is verified as fixed on Firefox 69.0a1 (20190522152821) and Firefox 68.0b3 (20190521110747) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.