Closed Bug 1549465 Opened 5 years ago Closed 9 months ago

[meta] Page.addScriptToEvaluateOnNewDocument

Categories

(Remote Protocol :: CDP, task)

task

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

()

Details

(Keywords: meta, Whiteboard: [method=Page.addScriptToEvaluateOnNewDocument])

No description provided.
Keywords: meta
Whiteboard: [method=Page.addScriptToEvaluateOnNewDocument]

This BZ does not provide much information what it is about - is it tracker for addScriptToEvaluateOnNewDocument to be implemented?
I was trying to use firefox remote protocol and this method did not work for me - although it returned success.
If it is supposed to work then I'll open issue where I post reproducer.

This is a meta bug and tracks the addition of the feature. It is indeed not supposed to work with any kind of version of Firefox yet.

Whiteboard: [method=Page.addScriptToEvaluateOnNewDocument] → [puppeteer-alpha]

This is called when Puppeteer initializes the FrameManager as part of _ensureIsolatedWorld, which is always present:

https://github.com/GoogleChrome/puppeteer/blob/master/lib/FrameManager.js#L66
https://github.com/GoogleChrome/puppeteer/blob/master/lib/FrameManager.js#L270

Currently we only have a placeholder, so it would have to be implemented.

Whiteboard: [puppeteer-alpha] → [method=Page.addScriptToEvaluateOnNewDocument][puppeteer-alpha]
Whiteboard: [method=Page.addScriptToEvaluateOnNewDocument][puppeteer-alpha] → [method=Page.addScriptToEvaluateOnNewDocument]

Maja, given that you worked on the basic implementation would you mind filing the remaining follow-up bugs to get the full feature set? Maybe we can make some of those mentored bugs? Thanks.

Flags: needinfo?(mjzffr)
Component: CDP: Page → CDP
Severity: normal → S3

All what we could do for CDP is done.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.