1601695 - Schedule script evaluation for scripts enqueued by Page.addScriptToEvaluateOnNewDocument's source argument

Status: RESOLVED WONTFIX

(Remote Protocol :: CDP, enhancement, P2)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

The content-document-global-created observer notification looks relevant.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Scripts to execute will actually be hold within the frame tree instance of the current target. That said we need its implementation done, which I'm working on via bug 1605359 right now. Once that is done we can use the frameAttached event to run all the registered scripts.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While Page.getFrameTree gives us the list of already existent frames so that a script added later will be run in all frames, we also need Page.frameAttached to call all the scripts when a new frame gets added. This can be done once bug 1599413 has been fixed.

Comment 3

[Marco Mucci [:MarcoM]]

Temporarily moving to Reserve Backlog as it is blocked on Bug 1599413 and to accommodate Bug 1599260 moving into the MVP Backlog.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As a side-node. When this gets implemented we will have to make sure that tests also check for the correct frameId reported in the generated execution contexts, especially for a test which navigates to a frameset. I would like to defer those tests for now because without bug 1637640 been done, it is very hard to do.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Over on bug 1806413 we are getting this feature currently implemented for WebDriver BiDi.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We are not going to finish this API for CDP while WebDriver BiDi has full support via script.addPreloadScript already.