Closed Bug 1551232 Opened 2 years ago Closed 1 year ago

Remove the legacy-urlbar binding and simplify gURLBarHandler

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
Future
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Status
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: mak, Assigned: harry, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The binding can go away and gURLBarHandler can be simplified, potentially even removed, if we move some of its handling to UrlbarInput

Blocks: 1513337
Priority: P3 → P2

Harry, want to prepare a patch for this? We can land this once 69 has moved to beta on July 8th.

Flags: needinfo?(htwyford)
Blocks: 1528614

To be clear, the binding is literally called legacy-urlbar and we can pretty much just rip this out:

https://searchfox.org/mozilla-central/search?q=legacy-urlbar&case=true

gURLBarHandler.toggleQuantumBarAttribute and gURLBarHandler._updateBinding are responsible for switching to the legacy binding so we can get rid of those as well.

Mentor: dao+bmo
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Flags: needinfo?(htwyford)
Iteration: --- → 69.4 - Jun 24 - Jul 7
OS: Unspecified → All
Hardware: Unspecified → All
Target Milestone: --- → Future
Blocks: 1551233
Blocks: 1562274

Harry, just a heads-up that you'll need to rebase your patch after bug 1562691 has landed.

(In reply to Dão Gottwald [::dao] from comment #4)

Harry, just a heads-up that you'll need to rebase your patch after bug 1562691 has landed.

Could you please rebase the patch so we can land it on Monday or Tuesday?

Flags: needinfo?(htwyford)

I just posted the rebased patch to Phabricator

Flags: needinfo?(htwyford)

(In reply to Harry Twyford [:harry] from comment #6)

I just posted the rebased patch to Phabricator

I think bug 1561435 just obsoleted your patch again...

Flags: needinfo?(htwyford)

Rebased again.

Flags: needinfo?(htwyford)
Blocks: 1534455
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07d42b08b863
Removes legacy-urlbar binding, simplifies gURLBarHandler, and removes ini file with legacy-urlbar tests. r=dao

you must remove the tests in bug 1551233 before you can remove the code

No longer blocks: 1551233
Depends on: 1551233
Attachment #9074578 - Attachment description: Bug 1551232 - Removes legacy-urlbar binding, simplifies gURLBarHandler, and removes ini file with legacy-urlbar tests. r?dao → Bug 1551232 - Removes legacy-urlbar binding and simplifies gURLBarHandler. r?dao

Marco's right that bug 1551233 must be applied first. I've posted new patches for both that bug and this one.

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17e167ce247f
Removes legacy-urlbar binding and simplifies gURLBarHandler. r=dao
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Blocks: 1564830
Blocks: 1529552
You need to log in before you can comment on or make changes to this bug.