1551232 - Remove the legacy-urlbar binding and simplify gURLBarHandler

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Marco Bonardo [:mak]]

The binding can go away and gURLBarHandler can be simplified, potentially even removed, if we move some of its handling to UrlbarInput

Comment 1

[Dão Gottwald [:dao]]

Harry, want to prepare a patch for this? We can land this once 69 has moved to beta on July 8th.

Comment 2

[Dão Gottwald [:dao]]

To be clear, the binding is literally called legacy-urlbar and we can pretty much just rip this out:

https://searchfox.org/mozilla-central/search?q=legacy-urlbar&case=true

gURLBarHandler.toggleQuantumBarAttribute and gURLBarHandler._updateBinding are responsible for switching to the legacy binding so we can get rid of those as well.

Comment 3

[Harry Twyford]

Attachment: Bug 1551232 - Removes legacy-urlbar binding and simplifies gURLBarHandler. r?dao

Comment 4

[Dão Gottwald [:dao]]

Harry, just a heads-up that you'll need to rebase your patch after bug 1562691 has landed.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #4)

Harry, just a heads-up that you'll need to rebase your patch after bug 1562691 has landed.

Could you please rebase the patch so we can land it on Monday or Tuesday?

Comment 6

[Harry Twyford]

I just posted the rebased patch to Phabricator

Comment 7

[Dão Gottwald [:dao]]

(In reply to Harry Twyford [:harry] from comment #6)

I just posted the rebased patch to Phabricator

I think bug 1561435 just obsoleted your patch again...

Comment 8

[Harry Twyford]

Rebased again.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07d42b08b863
Removes legacy-urlbar binding, simplifies gURLBarHandler, and removes ini file with legacy-urlbar tests. r=dao

Comment 10

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 07d42b08b863 (Bug 1551232) for bc failures at browser_action_searchengine.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/2f0ecb897063c2d07f83d25de412a2568c41f7e1

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=07d42b08b86341856cd8d8246357a03363faf881&selectedJob=255400271

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255400271&repo=autoland&lineNumber=20756

Comment 11

[Marco Bonardo [:mak]]

you must remove the tests in bug 1551233 before you can remove the code

Comment 12

[Harry Twyford]

Marco's right that bug 1551233 must be applied first. I've posted new patches for both that bug and this one.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e167ce247f
Removes legacy-urlbar binding and simplifies gURLBarHandler. r=dao

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/17e167ce247f