Closed Bug 1555150 Opened 5 months ago Closed 5 months ago

adding support for text-underline-offset to the style system

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: cmarlow, Assigned: cmarlow)

References

Details

Attachments

(1 file)

Adding support for underline offsets as described in the CSS spec listed below
https://drafts.csswg.org/css-text-decor-4/#underline-offset

Assignee: nobody → charles.w.marlow
Priority: -- → P3
Keywords: checkin-needed
Blocks: 1556041
Attachment #9068869 - Attachment description: Bug 1555150: adding support for CSS text underline offset to the style system by enabling various tests, adding a member variable to the nsStyleText struct, modifying its constructors and CalcDifference function, and adding some rust code in the... → Bug 1555150: adding support for CSS text underline offset to the style system r?emilio,dholbert
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/118a2ee53436
adding support for CSS text underline offset to the style system r=emilio

Keywords: checkin-needed

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=118a2ee534364fc3162d9ad1bc15b9089bab3730&searchStr=xpc&selectedJob=249495980

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249495980&repo=autoland&lineNumber=2449
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249496600&repo=autoland&lineNumber=4977

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c8509157a9ffb46ba1a093354cd31255ab6f868

[task 2019-05-31T23:11:45.448Z] 23:11:45 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 40] The preferences match on the client and platform. If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run mach devtools-css-db to re-generate the client side properties

Flags: needinfo?(charles.w.marlow)
Flags: needinfo?(charles.w.marlow)

It looks like I needed to update the properties-db.js database by running ./mach devtools-css-db which created and destroyed different XPCOM objects

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba1f75c56457
adding support for CSS text underline offset to the style system r=emilio

Keywords: checkin-needed
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c1170685b543
Backed out changeset ba1f75c56457 for xpcshell failures at  devtools/shared/tests/unit/test_css-properties-db.js

Fixed it by removing text-decoration-width from property database. Also added text-underline-offset to devtools/server/actors/animation-type-longhand.js to fix another failed test case.

Keywords: checkin-needed
Blocks: 1555863

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26eb4a5540b
adding support for CSS text underline offset to the style system r=emilio

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.