adding support for text-underline-offset to the style system
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: cmarlow, Assigned: cmarlow)
References
Details
Attachments
(1 file)
Adding support for underline offsets as described in the CSS spec listed below
https://drafts.csswg.org/css-text-decor-4/#underline-offset
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
...inherited_text.mako.rs file
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/118a2ee53436
adding support for CSS text underline offset to the style system r=emilio
Comment 5•5 years ago
•
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249495980&repo=autoland&lineNumber=2449
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249496600&repo=autoland&lineNumber=4977
Backout link: https://hg.mozilla.org/integration/autoland/rev/9c8509157a9ffb46ba1a093354cd31255ab6f868
[task 2019-05-31T23:11:45.448Z] 23:11:45 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 40] The preferences match on the client and platform. If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run mach devtools-css-db
to re-generate the client side properties
Assignee | ||
Comment 6•5 years ago
|
||
Thanks! TYlin suggested a fix and it's being tested here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8690170e40173487177e03172021bd49b3b33552
Assignee | ||
Comment 7•5 years ago
|
||
It looks like I needed to update the properties-db.js database by running ./mach devtools-css-db which created and destroyed different XPCOM objects
Assignee | ||
Comment 8•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba1f75c56457
adding support for CSS text underline offset to the style system r=emilio
Comment 10•5 years ago
|
||
Backout by btara@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/c1170685b543 Backed out changeset ba1f75c56457 for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Fixed it by removing text-decoration-width from property database. Also added text-underline-offset to devtools/server/actors/animation-type-longhand.js to fix another failed test case.
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26eb4a5540b
adding support for CSS text underline offset to the style system r=emilio
Comment 14•5 years ago
|
||
bugherder |
Description
•