1555150 - adding support for text-underline-offset to the style system

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

Adding support for underline offsets as described in the CSS spec listed below
https://drafts.csswg.org/css-text-decor-4/#underline-offset

Comment 1

[Charlie Marlow [:cmarlow]]

Attachment: Bug 1555150: adding support for CSS text underline offset to the style system r?emilio,dholbert

...inherited_text.mako.rs file

Comment 2

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=270239e1952a7df777b764dd1d6a287b9759a624

Comment 3

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ceb331fd935df85689247326fb9a1385c5b13276

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/118a2ee53436
adding support for CSS text underline offset to the style system r=emilio

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=118a2ee534364fc3162d9ad1bc15b9089bab3730&searchStr=xpc&selectedJob=249495980

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249495980&repo=autoland&lineNumber=2449
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249496600&repo=autoland&lineNumber=4977

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c8509157a9ffb46ba1a093354cd31255ab6f868

[task 2019-05-31T23:11:45.448Z] 23:11:45 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 40] The preferences match on the client and platform. If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run mach devtools-css-db to re-generate the client side properties

Comment 6

[Charlie Marlow [:cmarlow]]

Thanks! TYlin suggested a fix and it's being tested here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8690170e40173487177e03172021bd49b3b33552

Comment 7

[Charlie Marlow [:cmarlow]]

It looks like I needed to update the properties-db.js database by running ./mach devtools-css-db which created and destroyed different XPCOM objects

Comment 8

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f65e1f7566d7273939f1f2ff88ab48f47e93dfc4&selectedJob=249795653

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba1f75c56457
adding support for CSS text underline offset to the style system r=emilio

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c1170685b543
Backed out changeset ba1f75c56457 for xpcshell failures at  devtools/shared/tests/unit/test_css-properties-db.js

Comment 11

[Charlie Marlow [:cmarlow]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c92a96fb6d7d3e870d227d9593fe668f74de3a7b

Comment 12

[Charlie Marlow [:cmarlow]]

Fixed it by removing text-decoration-width from property database. Also added text-underline-offset to devtools/server/actors/animation-type-longhand.js to fix another failed test case.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26eb4a5540b
adding support for CSS text underline offset to the style system r=emilio

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b26eb4a5540b