1553682 - Context menus and menu popups are not dark in the dark theme

Status: RESOLVED DUPLICATE of bug 1681822

(Firefox :: Theme, defect, P3)

Description

[Majestic12]

Attachment: sdf.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Right click on a bookmark/bookmarks toolbar/tab/web page/toolbar element (like add-on icon, search bar or address bar) while theme is set to dark.

Actual results:

Menus' background is still light.

Expected results:

The background of the right click context menus should have been dark.

Comment 3

[Tom S]

Could this be prioritized? This is from what I can tell probably the biggest source of brightness in dark mode.

Comment 4

[alex_mayorga]

[Tracking Requested - why for this release]:

Comment 5

[VioletStorm]

Issue still persists, this should be prioritized if possible.

Comment 6

[alex_mayorga]

[Tracking Requested - why for this release]:

UX is jarring for users of the built in dark theme.

Comment 7

[Boris Lassort]

Please finish your dark theme.
This should realy be prioritized, a feature half completed for so long.

Comment 8

[[e-mail]]

Is this still being considered?

Comment 9

[[e-mail]]

(In reply to [e-mail] from comment #8)

Is this still being considered?

Context menus on Windows 10 would also look better if they are themed like the Photon popups from the rest of the application. Ex. clicking on the three dots button under Top sites provides a menu, right-click context menus should emulate this look.

Comment 11

[Adrian]

More than 2 years have passed and Mozilla still cannot correct this bug.
I love Firefox but it's really annoying to see the lack of uniformity in the interface.
I hope that someday we will be able to see a congruent dark theme in this great browser.

Comment 12

[Hossein Mortazavi]

(In reply to Adrian from comment #11)

More than 2 years have passed and Mozilla still cannot correct this bug.
I love Firefox but it's really annoying to see the lack of uniformity in the interface.
I hope that someday we will be able to see a congruent dark theme in this great browser.

I hope so 🤦

Comment 13

[Justin Peter]

I'm looking at where I would have to change to fix this, would putting a background under prefers-color-scheme in https://searchfox.org/mozilla-central/source/browser/themes/shared/contextmenu.inc.css work?

Comment 14

[quadronom]

Tracking stops with Firefox 80. :D
We are at 85 now.
Any sort of ETA here?

This should be an easy fix after all; the Windows Explorer has dark context menus, too.

Comment 15

[Justin Peter]

This may be resolved with bug 1681822? (I specifically see mention of dark mode in bug 1682522.)

Comment 16

[Tim Nguyen :ntim]

Windows 10 is covered by bug 1682522, macOS by bug 1475520, Linux has always supported system themes.

Comment 17

[michal.fita]

@(In reply to Tim Nguyen :ntim from comment #16)

Windows 10 is covered by bug 1682522, macOS by bug 1475520, Linux has always supported system themes.

*** This bug has been marked as a duplicate of bug 1681822 ***

1682522 seem to be done for 87, but that's the version I have installed and my menus are still grey.