1556582 - Restore context menus that got lost in bug 1532595 (xul:textbox multiline -> html:textarea)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: addrbook.patch

This is a spin-off from bug 1556203.

As per bug 1556203 comment #25, we need to add to scripts to the affected files.

Sample patch restoring the address book notes (under Other) attached.

Richard, do you have time for this?

EDIT: We need to revisit all the XUL files touched here https://hg.mozilla.org/comm-central/rev/994cd1a152ed and include the scripts unless they are already included, and then of course check that the text areas work.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1556582-restore-edit-context-menu.patch

Yes, almost every XUL with converted multiline textbox needed the scripts.

I added messenger.xul too to get the meno on QFB searchbox too. I haven't touched EdTextAreaProps.xul because we don't use it on TB.

The certpicker.xul had an issue that the menulist wasn't filled correctly. Fixed it. Jörg, can you check, that the certpicker.xul works correctly on Beta?

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9069743 [details] [diff] [review]
1556582-restore-edit-context-menu.patch

Thanks, looks OK by visual inspection. The cert picker (in the account settings under security, yes?) is broken on the beta I'm using.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/72186adac207
Restore context menus that got lost in bug 1532595. r=jorgk

Comment 4

[Jorg K (CEST = GMT+2)]

This got landed with the wrong author. I saw it too late and didn't want to scrap five patches on top.

Comment 5

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/010ad7b5cded8e46aa57c0ac1f84acfbc6c460ed

Landed with the correct author this time. The wrong/missing context menu in the address book search will be fixed in bug 1556839.