1557018 - Massive Mozmill failure 2019-06-05: Fix Calender tests after bug 1544916

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Failing in mozmill/newmailaccount/test-newmailaccount.js and many calendar tests in mozmill/cal-recurrence/testLastDayOfMonthRecurrence.js and more.

https://taskcluster-artifacts.net/Bx4QidoNQN68iyH57qwTZQ/0/public/logs/live_backing.log
says:
EXCEPTION: waitFor: Timeout exceeded for '() => { return menulist.value == aValue; }'
EXCEPTION: Expression "{"anonid":"buttons"}" returned null. Anonymous == true

Looks like a de-XBL issue. I can't see it in the regression range right now:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=21d22b2f541258d3d1cf96c7ba5ad73e96&tochange=155a7e2117e575ff6de6caa3dfe5b076cb

That's the lunchtime merge.

It would be bug 1556375 or anything else we landed?

I'm afk for a while and can't investigate further.

Comment 1

[Jorg K (CEST = GMT+2)]

OK, it's from here:
843c150636f81fb2f13196844206514f8a938bd9 Alexander Surkov — Bug 1544916 - migrate dialog binding to Custom Element r=bgrins,whimboo

There are changes removing the getAnonymousElementByAttribute:
https://hg.mozilla.org/mozilla-central/rev/843c150636f81fb2f13196844206514f8a938bd9#l7.14

We already a bug to port bug 1544916, that is bug 1557006, but that doesn't go far enough.

Comment 2

[Jorg K (CEST = GMT+2)]

OK, so the "anonid":"buttons" needs to be replaced:
https://searchfox.org/comm-central/search?q=%22anonid%22%3A%22buttons%22&case=true&regexp=false&path=

Maybe something like this:
https://hg.mozilla.org/comm-central/rev/b38b8ba2148b535c76ad39ad57373e734123d198#l1.12

That will most likely fix the Calendar tests, leaving mozmill/newmailaccount/test-newmailaccount.js.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1557018-calendar-fix.patch

Jörg, can you try this patch locally if it fixes the anonid failures?

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9069973 [details] [diff] [review]
1557018-calendar-fix.patch

Still failing. This needs someone that knows the tests.

Comment 5

[Magnus Melin [:mkmelin]]

For newmailaccount/test-newmailaccount.js I think there could be something else. It shows a bunch of

JavaScript error: chrome://messenger/content/newmailaccount/accountProvisioner.js, line 36: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMStorageManager.createStorage]

Comment 6

[Jorg K (CEST = GMT+2)]

OK, that looks like bug 1555562 then, but there weren't changes to createStorage:
https://hg.mozilla.org/mozilla-central/rev/d39a023bdbb63114e2824c3d4d46a81c2c05bbd6

For the record, we have two of these calls in the system:
mail/components/newmailaccount/content/accountProvisioner.js
36 return Services.domStorageManager.createStorage(null, principal, principal, url);

mail/test/mozmill/newmailaccount/test-newmailaccount.js
1208 let storage = dsm.createStorage(null, principal, principal, url);

Nihanth, do we need to make any adjustment there?

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Based on my basic understanding of storage principal, I don't know why the change in bug 1555562 would cause that error. Forwarding to Ehsan.

Comment 8

[Magnus Melin [:mkmelin]]

For the calendar tests, the thing is that the selectors won't work now because shadow dom is used, and the buttons are under the dialog shadowRoot, so the selectors can't access. :(
It should be fixable by first "selecting" the dialog and then doing the dlg.shadowRoot.querySelector()

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53cdd29d9280
Teach Mozmill about shadow DOM and fix broken calendar tests; rs=bustage-fix

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: 1557018-mozmill-shadow-1.diff

I guess somebody'd better review this.

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 9070155 [details] [diff] [review]
1557018-mozmill-shadow-1.diff

Review of attachment 9070155 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, though of course it's a hack and non-standard syntax. Thanks for fixing!
It's really quite annoying that we use these xpaths for selectors in calendar. Once anonymous content is gone, we should get rid of all the special junk and just do querySelector everywhere

Comment 12

[Jorg K (CEST = GMT+2)]

Thanks, Geoff. I'll move the other failure to a new bug to avoid confusion.

Comment 13

[Jorg K (CEST = GMT+2)]

Filed bug 1557233.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3a368a1bca2
follow-up - Tidy a slight mess; rs=me