Closed Bug 1567417 Opened 6 years ago Closed 5 years ago

Standardize hovering effect in "Tracking Protection" menu

Categories

(Firefox :: Site Identity, defect, P1)

Product:
Firefox
Component:
Site Identity
Version:
70 Branch
Platform:
x86_64
Windows 7
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- verified

People

(Reporter: Virtual, Assigned: timhuang)

References

Details

(Keywords: nightly-community, regression, ux-consistency, Whiteboard: [privacy-panel][skyline])

Attachments

(7 files, 3 obsolete files)

no bug - Tracking Content hovering effect.png
33.28 KB, image/png
Details
no bug - Social Media Trackers hovering effect.png
33.35 KB, image/png
Details
no bug - Cookies hovering effect.png
33.40 KB, image/png
Details
no bug - Fingerprinters hovering effect.png
33.38 KB, image/png
Details
bug - Protection Settings hovering effect.png
34.02 KB, image/png
Details
bug - Show Full Report hovering effect.png
34.20 KB, image/png
Details
Bug 1567417 - Make the buttons in the footer section of the protections panel to ignore the appearance setting of the toolbarbutton. r?nhnt11!
47 bytes, text/x-phabricator-request
Details | Review
Attached image no bug - Trackers hovering effect.png (obsolete) —

Standardize hovering effect in "Tracking Protection" menu.

STR:

  1. Open "Tracking Protections" menu
    and see that "Trackers" and "Cookies" items have Photon hovering style,
    but "Protection Settings" item has some kind of Microsoft Vista/7 hovering style, while it should also has Photon hovering style like "Trackers" and "Cookies" items.
Component: Address Bar → Site Identity and Permission Panels

:Virtual, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Whiteboard: [privacy-panel][triage]
Priority: -- → P1
Whiteboard: [privacy-panel][triage] → [skyline]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---

I think this is the windows equivalent of bug 1571898, which certainly makes it higher priority. We'll look at it in triage. Thanks for re-opening!

Priority: P1 → --
Whiteboard: [skyline] → [privacy-panel][skyline]
See Also: → 1571898

"Protection Settings" and now also "Show Full Report" has some kind of Microsoft Vista/7 hovering style, instead of Photon hovering style. Latest change was done in bug #1555231.

Has Regression Range: --- → yes

I want also to add that hovering over "X Blocked" in "Show Full Report" loses hovering effect of whole verse.

The priority flag is not set for this bug.
:johannh, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jhofmann)
Flags: needinfo?(jhofmann)
Priority: -- → P1
Assignee: nobody → tihuang
Status: NEW → ASSIGNED

I believe the root cause here is that I missed the rule '-moz-appearance: none;' on the .protections-popup-footer-button. I will add it.

We need to overwrite the '-moz-appearance' CSS rule of the buttons in
the footer section of the protections panel in order to properly style
the buttons.

Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21bd83f9fa50 Make the buttons in the footer section of the protections panel to ignore the appearance setting of the toolbarbutton. r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/21bd83f9fa50

Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 5 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-08-17), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: