Closed Bug 1570631 Opened 2 months ago Closed 9 days ago

Implement feature promotion doorhangers using CFR

Categories

(Firefox :: Tracking Protection, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [skyline] [stp])

Attachments

(6 files, 4 obsolete files)

No description provided.
Priority: P2 → P1
Whiteboard: [skyline] [stp]
Attachment #9087437 - Attachment is obsolete: true

A couple of questions:

  • Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
  • What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

  • Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.

We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.

  • What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Tony, could you help with this question?

Flags: needinfo?(tcinotto)
Attachment #9087445 - Attachment description: Bug 1570631 - Part 3: add translation files; → Bug 1570631 - Part 2: add translation files;
Attachment #9087436 - Attachment description: Bug 1570631 - Part 1: support basic popup; → Bug 1570631 - Part 3: implement doorhangers using CFR;
Attachment #9087444 - Attachment is obsolete: true

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

  • Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
  • What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.

And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview

Cindy
(In reply to Gary Chen [:xeonchen] from comment #6)

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

  • Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.

We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.

  • What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Tony, could you help with this question?

Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.

And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview

Cindy

Flags: needinfo?(tcinotto)
  1. make popupIconURLsupport icon for dark theme
  2. support recommendation.anchorId
  3. support recommendation.skipAddressBarNotifier
  1. make larger icon in popup optional
  2. add data-notification-bucket to support CSS on specific element
  3. set CSS for CFR_SOCIAL_TRACKING_PROTECTION
Attachment #9088414 - Attachment is obsolete: true
Attachment #9090354 - Attachment is obsolete: true
Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4ad27f27eb86
Part 1: refactoring; r=k88hudson,andreio
https://hg.mozilla.org/integration/autoland/rev/5e87be03a7a1
Part 1.1: popup enhancement; r=k88hudson
https://hg.mozilla.org/integration/autoland/rev/6b93718550af
Part 2: add translation files; r=fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/cb70d2019301
Part 3: implement doorhangers using CFR; r=k88hudson
https://hg.mozilla.org/integration/autoland/rev/94c10676584a
Part 4 migrate doorhanger to cfr; r=johannh
https://hg.mozilla.org/integration/autoland/rev/26009ef5fd47
Part 5: test cases; r=k88hudson
You need to log in before you can comment on or make changes to this bug.