1570631 - Implement feature promotion doorhangers using CFR

Status: RESOLVED FIXED

(Firefox :: Protections UI, task, P1)

Comment 1

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 3: implement doorhangers using CFR;

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 2: implement doorhangers using CFR;

Comment 3

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 2: implement doorhangers using CFR;

Comment 4

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 2: add translation files;

Comment 5

[Francesco Lodolo [:flod]]

A couple of questions:

• Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
• What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Comment 6

[Gary Chen [:xeonchen]]

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

• Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.

We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.

• What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Tony, could you help with this question?

Comment 7

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 1: refactoring;

Comment 8

[Gary Chen [:xeonchen]]

Attachment: use local ASR provider & CFRMessageProvider to test

Comment 9

[chsiang]

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

• Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
• What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.

And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview

Cindy
(In reply to Gary Chen [:xeonchen] from comment #6)

(In reply to Francesco Lodolo [:flod] from comment #5)

A couple of questions:

• Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.

We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.

• What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.

Tony, could you help with this question?

Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.

And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview

Cindy

Comment 10

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 4 migrate doorhanger to cfr;

Comment 11

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 5: test cases;

Comment 12

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 1.1: popup enhancement;

1. make popupIconURLsupport icon for dark theme
2. support recommendation.anchorId
3. support recommendation.skipAddressBarNotifier

Comment 13

[Gary Chen [:xeonchen]]

Attachment: Bug 1570631 - Part 6: UI adjustment for spec;

1. make larger icon in popup optional
2. add data-notification-bucket to support CSS on specific element
3. set CSS for CFR_SOCIAL_TRACKING_PROTECTION

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad27f27eb86
Part 1: refactoring; r=k88hudson,andreio
https://hg.mozilla.org/integration/autoland/rev/5e87be03a7a1
Part 1.1: popup enhancement; r=k88hudson
https://hg.mozilla.org/integration/autoland/rev/6b93718550af
Part 2: add translation files; r=fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/cb70d2019301
Part 3: implement doorhangers using CFR; r=k88hudson
https://hg.mozilla.org/integration/autoland/rev/94c10676584a
Part 4 migrate doorhanger to cfr; r=johannh
https://hg.mozilla.org/integration/autoland/rev/26009ef5fd47
Part 5: test cases; r=k88hudson

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4ad27f27eb86
https://hg.mozilla.org/mozilla-central/rev/5e87be03a7a1
https://hg.mozilla.org/mozilla-central/rev/6b93718550af
https://hg.mozilla.org/mozilla-central/rev/cb70d2019301
https://hg.mozilla.org/mozilla-central/rev/94c10676584a
https://hg.mozilla.org/mozilla-central/rev/26009ef5fd47