Closed Bug 1572129 Opened 6 years ago Closed 6 years ago

Simplify and harmonise cookieViewer and permissionsManager code

Categories

(SeaMonkey :: Passwords & Permissions, task)

Product:
SeaMonkey
Component:
Passwords & Permissions
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.67
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 3 obsolete files)

Harmonisation patch v1.3
31.96 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Carrying out the following tasks:

  • Simplify the handling of treecols in both sets of code
  • Harmonise how permissions are loaded
  • Harmonise how buttons are enabled/disabled
  • Harmonise how key presses are handled
  • Show sort order in permissionsManager by setting sortDirection attribute on treecols
  • Move common code into treeUtils.js
  • Use clearSelection() rather than select(-1)
  • Use " rather than ' everywhere
Attached patch Harmonisation patch (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Applies on top of patches from bug 1570846 on relevant repos

Attachment #9083712 - Flags: review?(frgrahl)
Attachment #9083712 - Flags: approval-comm-release?
Attachment #9083712 - Flags: approval-comm-esr60?
Attached patch Harmonisation patch v1.1 (obsolete) — — Splinter Review

Changes since last version:

  • Switched to using tree.view.selection.count in PermissionSelected function.
Attachment #9083712 - Attachment is obsolete: true
Attachment #9083712 - Flags: review?(frgrahl)
Attachment #9083712 - Flags: approval-comm-release?
Attachment #9083712 - Flags: approval-comm-esr60?
Attachment #9084503 - Flags: review?(frgrahl)
Attachment #9084503 - Flags: approval-comm-release?
Attachment #9084503 - Flags: approval-comm-esr60?
Blocks: 1572976
Attached patch Harmonisation patch v1.2 (obsolete) — — Splinter Review

Unbitrotted to go on top of latest patch in bug 1209626

Attachment #9084503 - Attachment is obsolete: true
Attachment #9084503 - Flags: review?(frgrahl)
Attachment #9084503 - Flags: approval-comm-release?
Attachment #9084503 - Flags: approval-comm-esr60?
Attachment #9084532 - Flags: review?(frgrahl)
Attachment #9084532 - Flags: approval-comm-release?
Attachment #9084532 - Flags: approval-comm-esr60?

Added bonus fix:

  • Sort direction no longer reverses when clicking OK/Cancel button in permissionsManager
Attachment #9084532 - Attachment is obsolete: true
Attachment #9084532 - Flags: review?(frgrahl)
Attachment #9084532 - Flags: approval-comm-release?
Attachment #9084532 - Flags: approval-comm-esr60?
Attachment #9085444 - Flags: review?(frgrahl)
Attachment #9085444 - Flags: approval-comm-release?
Attachment #9085444 - Flags: approval-comm-esr60?
Comment on attachment 9085444 [details] [diff] [review] Harmonisation patch v1.3 Looks good. We should show the scheme in the permissions too but that can be done in another bug.
Attachment #9085444 - Flags: review?(frgrahl)
Attachment #9085444 - Flags: review+
Attachment #9085444 - Flags: approval-comm-release?
Attachment #9085444 - Flags: approval-comm-release+
Attachment #9085444 - Flags: approval-comm-esr60?
Attachment #9085444 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/29e0bcd5298e
Simplify and harmonise cookieViewer and permissionsManager code. r=frg

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

c-c and c-esr60: Also fixes stray Cu.import
esr60: Fix bad double .addObserver from rebase of patch for Bug 1570846

https://hg.mozilla.org/releases/comm-esr60/rev/30dfd87ce129bbf0ab026092f17a106c76a2cdd8

status-seamonkey2.49esr: --- → wontfix
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → fixed
status-seamonkey2.63: --- → wontfix
Target Milestone: --- → seamonkey2.67
status-seamonkey2.53: affected → fixed
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: