Closed Bug 1574507 Opened 6 years ago Closed 6 years ago

Update pageinfo to use SitePermissions.jsm

Categories

(SeaMonkey :: Page Info, task)

Product:
SeaMonkey
Component:
Page Info
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

Use SitePermissions v1.2
18.61 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port parts of the following:

  • Bug 889835 - Use SitePermissions.jsm as the backend for Page Info's Permissions tab
  • Bug 894877 - permissions.js onRadioClick tries to pass a host string to SitePermissions
  • Bug 1072889 - Replace array.indexOf(...) != -1 with array.contains(...)
  • Bug 1144493 - wallpaper over enough cracks to make page info work with e10s
  • Bug 1320557 - Prevent broken UI from invalid permission states
  • Bug 1299967 - Sort page permissions list alphabetically
  • Bug 1206232 - Add temporary permission states to SitePermissions.jsm
  • Bug 1331172 - Current permission state should use the past tense
Attached patch use SitePermissions (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Some permissions are missing
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: Some removed and one added

Attachment #9086099 - Flags: review?(frgrahl)
Attachment #9086099 - Flags: approval-comm-release?
Attachment #9086099 - Flags: approval-comm-esr60?
Blocks: 1574689

Adapted to use ChromeUtils

Attachment #9086099 - Attachment is obsolete: true
Attachment #9086099 - Flags: review?(frgrahl)
Attachment #9086099 - Flags: approval-comm-release?
Attachment #9086099 - Flags: approval-comm-esr60?
Attachment #9086248 - Flags: review?(frgrahl)
Attachment #9086248 - Flags: approval-comm-release?
Attachment #9086248 - Flags: approval-comm-esr60?

Also allow file scheme as a supported URI

Attachment #9086248 - Attachment is obsolete: true
Attachment #9086248 - Flags: review?(frgrahl)
Attachment #9086248 - Flags: approval-comm-release?
Attachment #9086248 - Flags: approval-comm-esr60?
Attachment #9088127 - Flags: review?(frgrahl)
Attachment #9088127 - Flags: approval-comm-release?
Attachment #9088127 - Flags: approval-comm-esr60?
Blocks: 1576618
Comment on attachment 9088127 [details] [diff] [review] Use SitePermissions v1.2 r/a= me lgtm
Attachment #9088127 - Flags: review?(frgrahl)
Attachment #9088127 - Flags: review+
Attachment #9088127 - Flags: approval-comm-release?
Attachment #9088127 - Flags: approval-comm-release+
Attachment #9088127 - Flags: approval-comm-esr60?
Attachment #9088127 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/3fe0df4dabbb
Update pageinfo to use SitePermissions.jsm. r=frg

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: