1576618 - Port |Bug 1330467 - Add SitePermissions APIs functions to accept principal and use them| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, task)

Description

[Ian Neal]

Port the following:

• Bug 1330467 - part 2. Add SitePermissions APIs functions to accept principal
• Bug 1330467 - part 3. Use principal for permissions in pageinfo/permissions.js
• Bug 1330467 - part 5. Access permissions by principal in PermissionUI.jsm

Comment 1

[Ian Neal]

Attachment: Use principals

[Approval Request Comment]
Regression caused by (bug #): None
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9088129 [details] [diff] [review]
Use principals

Works fine. r/a+++

Comment 3

[Frank-Rainer Grahl (:frg)]

NIT description of isSupportedPrincipal and isSupportedURI (oversight from Bug 1574507) is wrong. We added the file protocol and it works fine. Fix it here or in a follow-up?

Comment 4

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

NIT description of isSupportedPrincipal and isSupportedURI (oversight from Bug 1574507) is wrong. We added the file protocol and it works fine. Fix it here or in a follow-up?

Yes, remove the part of the comment about file protocol.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1b84ea4d5b17
Port Bug 1330467 "Add SitePermissions APIs functions to accept principal and use them" to SeaMonkey. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/e71c6693877fc37d1d3da784cac30a8c6d398406

Comment 7

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ff81d85f2a003d31b4c684465e4fb31838a5da8e