1575478 - Dark extension icons are hard to see in dark mode

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Itiel]

Attachment: Screenshot

See attached.

I see this rule which was added in bug 1544111:
https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/toolkit/mozapps/extensions/content/shortcuts.css#22-23
but -moz-context-properties and fill don't seem to have any effect.

Comment 1

[Mark Striemer [:mstriemer]]

There's an option for browser actions for the extension author to specify an icon to use with a dark theme. There's also bug 1398156 to do the same thing for page actions. We'll likely need something similar for the extension icon itself.

Another option would be to put a white background behind the icon, which I'm not especially crazy about. I think Emanuela had also suggested leaving the cards as white, but on a dark page.

Emanuela, should we allow extensions to specify a different icon for this or is there some other approach you'd like us to take here?

Comment 2

[emanuela [ux]]

(In reply to Mark Striemer [:mstriemer] from comment #1)

There's an option for browser actions for the extension author to specify an icon to use with a dark theme. There's also bug 1398156 to do the same thing for page actions. We'll likely need something similar for the extension icon itself.

Another option would be to put a white background behind the icon, which I'm not especially crazy about. I think Emanuela had also suggested leaving the cards as white, but on a dark page.

Emanuela, should we allow extensions to specify a different icon for this or is there some other approach you'd like us to take here?

I think allowing extensions to have different icons according to the a dark or light background can be something worth exploring.