1576399 - window buttons are clipped on MacOS when CoreAnimation is enabled (by default now)

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Sébastien Desvignes]

Attachment: Capture d’écran 2019-08-24 à 20.53.53.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

I use the drag space option in the customize page

Actual results:

The window buttons are clipped (see capture)

Comment 1

[Sébastien Desvignes]

Attachment: Capture d’écran 2019-08-24 à 20.59.32.png

Even when not using the drag space option, the buttons are not perfectly round

Comment 2

[Flore Allemandou [:flore]]

Hello,

I confirm this bug, mozregression performed:
11:11.34 INFO: Last good revision: 92bb542ff11aa1f133a27ac7a445a71c79dde661
11:11.34 INFO: First bad revision: 152bfc05a5091be5d366580d6cbdd1e6fd54eb79
11:11.34 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=92bb542ff11aa1f133a27ac7a445a71c79dde661&tochange=152bfc05a5091be5d366580d6cbdd1e6fd54eb79

It seems that a good candidate for this regression is bug 1574538 (coreanimation) hence ping mstange

Comment 3

[Markus Stange [:mstange]]

This will be fixed by the change I just landed in bug 1576113. I've filed bug 1576388 for coming up with a more long-term fix.

Comment 4

[Markus Stange [:mstange]]

Thanks for the screenshots! I wasn't aware that this problem was more severe on non-HiDPI and I had forgotten about the extra drag space option. I'll add that option to the list of things I have to test this type of change with.

Comment 5

[Markus Stange [:mstange]]

That change has merged to mozilla-central, so this bug should be fixed now.

Comment 6

[Flore Allemandou [:flore]]

Attachment: no window button

Comment 7

[Flore Allemandou [:flore]]

Hi Marcus,

I downloaded the latest mozilla central, and now the window buttons completely disappeared. See screenshot.

Comment 8

[Markus Stange [:mstange]]

I'm not seeing this problem. Both on 10.12 and on 10.14, the window buttons are present in the current Nightly.

Which version of macOS are you seeing this on? Does turning off CoreAnimation fix it?

Comment 9

[Flore Allemandou [:flore]]

I am on 10.13.6 (High Sierra) and so is Sébastien and if I turn off CoreAnimation, the buttons are back.

Comment 10

[Markus Stange [:mstange]]

Hah, what a mess.

Thanks! I'm going to close this bug again because the original problem (partially clipped window buttons) is indeed fixed.

I've filed bug 1576483 to track the problem of missing window buttons on 10.13.

Comment 11

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with latest Nightly 74.0a1 (2020-02-09) and Firefox 73.0 on macOS 10.13.6, macOS 10.15.