1576601 - Inside the panel, the whole text is an hyperlink

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Oana Botisan, Desktop QA]

Affected versions

• Firefox 70.a01

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64
• macOS 10.13

Steps to reproduce

1. Open any site with a new profile or click on the shield icon from URL bar and then on the "i" symbol.
2. Click anywhere on the text: "Browse without being followed..."

Expected result
I think there are two different results that could happen here:

• Nothing happens.
  or
• The cursor changes and the text has a link hover effect and after the click, the "Learn more" page opens in a new tab.

Actual result

• The "Learn more" page opens in a new tab.

Regression range

• I don't think this is a regression.

Additional notes

• This might be an issue because some people have the habit of selecting the text while reading it and it could become frustrating.

Comment 1

[Johann Hofmann [:johannh]]

Hah, having said habit I completely agree with this.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Interesting! Seems like there have been a couple of changes to the info message that I wasn't aware of, and this was one of them.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

One more for your triage - sounds like a polish issue but maybe would be nice to fix for 70. Up to you!

Comment 4

[Johann Hofmann [:johannh]]

Yeah, sorry, our triage link was broken and missed this. We'll look at it today.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

I think a simple fix for this would be to make only the Learn More text clickable, and there's another bug to style it properly on hover.

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1576601 - Add click listener only to the link in the protections panel info message. r=andreio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8919c0d489c
Add click listener only to the link in the protections panel info message. r=andreio

Comment 8

[Cristina Coroiu [:ccoroiu]]

Backed out 4 changesets (bug 1583355, bug 1576600, bug 1576601, bug 1583350) for browser-chrome failures at browser/base/content/test/siteProtections/browser_protections_UI.js

Backout: https://hg.mozilla.org/integration/autoland/rev/283763664a4b94cdfe9124846cdb04114c197440

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d1fe84998565c0a1f22979b467eb4e21862dc5c0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269024083&repo=autoland&lineNumber=6488

[task 2019-09-30T11:07:41.359Z] 11:07:41 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | recorded full_report telemetry event -
[task 2019-09-30T11:07:41.360Z] 11:07:41 INFO - Leaving test bound testShowFullReportButton
[task 2019-09-30T11:07:41.360Z] 11:07:41 INFO - Entering test bound testMiniPanel
[task 2019-09-30T11:07:41.361Z] 11:07:41 INFO - Buffered messages finished
[task 2019-09-30T11:07:41.361Z] 11:07:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-mainView-panel-header-section' is hidden in the toast. -
[task 2019-09-30T11:07:41.362Z] 11:07:41 INFO - Stack trace:
[task 2019-09-30T11:07:41.362Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-30T11:07:41.363Z] 11:07:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:testMiniPanel:277
[task 2019-09-30T11:07:41.363Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1350
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1385
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3f8a8212d3a
Add click listener only to the link in the protections panel info message. r=andreio

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d3f8a8212d3a

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9096923 [details]
Bug 1576601 - Add click listener only to the link in the protections panel info message. r=andreio

Beta/Release Uplift Approval Request

• User impact if declined: Inferior Skyline feature onboarding experience
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the protections panel and click the "i" icon at the top right.
• List of other uplifts needed: Bug 1583350, Bug 1576601, Bug 1576600, Bug 1583355
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a click listener to a different target element. Simple change, easy code review.
• String changes made/needed:

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9096923 [details]
Bug 1576601 - Add click listener only to the link in the protections panel info message. r=andreio

Polish for Skyline feature, fine for uplift for beta 12.

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/afca95b1be52

Comment 14

[Oana Botisan, Desktop QA]

I verified the fix using latest Nightly 71.0a1 and Firefox 70.0b12 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64. The issue is not reproducing anymore.