1583355 - [Protections Panel] Update margins of more info button

Status: VERIFIED FIXED

(Firefox :: Site Identity, task, P3)

Description

[Eric Pang [:epang] UX]

Attachment: more info button.png

Move the more info button so that it's 9px from the top and 9px from the right edge of the header.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1583355 - [Protections Panel] Update margins of more info button. r=johannh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78bbc490901b
[Protections Panel] Update margins of more info button. r=johannh

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out 4 changesets (bug 1583355, bug 1576600, bug 1576601, bug 1583350) for browser-chrome failures at browser/base/content/test/siteProtections/browser_protections_UI.js

Backout: https://hg.mozilla.org/integration/autoland/rev/283763664a4b94cdfe9124846cdb04114c197440

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d1fe84998565c0a1f22979b467eb4e21862dc5c0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269024083&repo=autoland&lineNumber=6488

[task 2019-09-30T11:07:41.359Z] 11:07:41 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | recorded full_report telemetry event -
[task 2019-09-30T11:07:41.360Z] 11:07:41 INFO - Leaving test bound testShowFullReportButton
[task 2019-09-30T11:07:41.360Z] 11:07:41 INFO - Entering test bound testMiniPanel
[task 2019-09-30T11:07:41.361Z] 11:07:41 INFO - Buffered messages finished
[task 2019-09-30T11:07:41.361Z] 11:07:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-mainView-panel-header-section' is hidden in the toast. -
[task 2019-09-30T11:07:41.362Z] 11:07:41 INFO - Stack trace:
[task 2019-09-30T11:07:41.362Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2019-09-30T11:07:41.363Z] 11:07:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:testMiniPanel:277
[task 2019-09-30T11:07:41.363Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1350
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1385
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1213
[task 2019-09-30T11:07:41.364Z] 11:07:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:805

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7c0ced757be
[Protections Panel] Update margins of more info button. r=johannh

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f7c0ced757be

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9096918 [details]
Bug 1583355 - [Protections Panel] Update margins of more info button. r=johannh

Beta/Release Uplift Approval Request

• User impact if declined: Inferior visual appearance
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1583350, Bug 1576601, Bug 1576600, Bug 1583355
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, visual polish.
• String changes made/needed:

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9096918 [details]
Bug 1583355 - [Protections Panel] Update margins of more info button. r=johannh

Polish for Skyline feature, fine for uplift for beta 12.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee4042738514

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed in Fx71.0a1 and Fx70.0b12 on Windows 10, macOS 10.13 and Ubuntu 18.04. The button now looks more polished and its margins easier to view.