Closed
Bug 1577659
Opened 5 years ago
Closed 5 years ago
Remove the statusbarpanel CE
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: darktrojan, Assigned: khushil324)
References
Details
Attachments
(1 file)
|
13.30 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
This is a pretty unnecessary binding, we could just use label, and it causes a layout warning every time it is changed:
"XUL box for statusbarpanel element contained an inline #text child, forcing all its children to be wrapped in a block."
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → khushil324
|
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9089310 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9089310 [details] [diff] [review] Bug-1577659_remove-statusbarpanel-CE.patch Review of attachment 9089310 [details] [diff] [review]: ----------------------------------------------------------------- Looks ok. r=mkmelin
Attachment #9089310 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Summary: Remove the statusbarpanel binding → Remove the statusbarpanel CE
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/aaa8e8ef1aa5
remove statusbarpanel custom element. r=mkmelin
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 70.0
Version: unspecified → Trunk
|
Reporter | |
Comment 5•5 years ago
|
||
Thanks Khushil. It's nice when stuff gets fixed without even having to ask.
You need to log in
before you can comment on or make changes to this bug.
Description
•