1577783 - In Browser Toolbox, clicking on an Element node target icon should navigate to the right node in the inspector

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This means we need to fix how we handle things now.
Because Reps only works on grips, it means that at some point in the action we need to retrieve the nodeFront that matches the grip.
As we move Fission forward, this will be tricky to do because we need to get the right (contextual) walker to do such thing, which isn't easy.

An easier way would be for Reps to simply handle fronts.

Since Reps is used in may places (inspector, debugger, console, …) this might be a significant task (but also one that we want to do to have a cleaner codebase).

Setting as P3 for now as we may want to do this as part of M2. We'll move it to M1 if we have enough time to do it.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1577783 - Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro.

Depends on D48809

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eec673dbb60
Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro,rcaliman.

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3eec673dbb60