Closed Bug 1586201 Opened 5 months ago Closed 4 months ago

Add a function to retrieve a nodeFront from a node grip, in the right context

Categories

(DevTools :: Console, task, P1)

task

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission dt-fission-m1)

Attachments

(3 files)

This will allow us to retrieve the right inspector front for a given node

Blocks: 1577783
Summary: Return browsing context id in element node grip → Add a function to retrieve a nodeFront from a node grip, in the right context
Blocks: 1587701

The function was close to hit the complexity limit set by eslint,
so we break it up into smaller functions.
We also group assignments where we can.

This will allow us to retrieve the appropriate inspector
(and thus walker, highlighter, ...) for a given element
on the client side.

Depends on D48806

A function is added on the walker actor that creates a NodeFront
from a ContentDomReference, e.g. an object containing a browsingContextId
and a unique DOM element identifier.
A trait is added on the walker actor since the ContentDomReference API was
only added in Firefox 69.
We then add a function on the toolbox that can return a NodeFront from a
element grip.

Depends on D48807

Attachment #9100108 - Attachment description: Bug 1586201 - Add a function to get a nodeFront from a ContentDomReference. r=pbro. → Bug 1586201 - Add a function to get a nodeFront from a ContentDomReference. r=pbro,jdescottes.
Blocks: 1589301
Blocks: 1589571
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9dada687889
Refactor of ObjectActor form function. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/1177ff81eab7
Include ContentDomReference in Node grips. r=pbro.
https://hg.mozilla.org/integration/autoland/rev/ba7304bbc693
Add a function to get a nodeFront from a ContentDomReference. r=pbro,jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Whiteboard: dt-fission → dt-fission dt-fission-m1
You need to log in before you can comment on or make changes to this bug.