1586201 - Add a function to retrieve a nodeFront from a node grip, in the right context

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This will allow us to retrieve the right inspector front for a given node

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1586201 - Refactor of ObjectActor form function. r=ochameau.

The function was close to hit the complexity limit set by eslint,
so we break it up into smaller functions.
We also group assignments where we can.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1586201 - Include ContentDomReference in Node grips. r=pbro.

This will allow us to retrieve the appropriate inspector
(and thus walker, highlighter, ...) for a given element
on the client side.

Depends on D48806

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1586201 - Add a function to get a nodeFront from a ContentDomReference. r=pbro,jdescottes.

A function is added on the walker actor that creates a NodeFront
from a ContentDomReference, e.g. an object containing a browsingContextId
and a unique DOM element identifier.
A trait is added on the walker actor since the ContentDomReference API was
only added in Firefox 69.
We then add a function on the toolbox that can return a NodeFront from a
element grip.

Depends on D48807

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9dada687889
Refactor of ObjectActor form function. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/1177ff81eab7
Include ContentDomReference in Node grips. r=pbro.
https://hg.mozilla.org/integration/autoland/rev/ba7304bbc693
Add a function to get a nodeFront from a ContentDomReference. r=pbro,jdescottes.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e9dada687889
https://hg.mozilla.org/mozilla-central/rev/1177ff81eab7
https://hg.mozilla.org/mozilla-central/rev/ba7304bbc693