Closed
Bug 1579053
Opened 5 years ago
Closed 5 years ago
pageStyles.getLayout fails with remote nodeFronts
Categories
(DevTools :: Inspector, task, P1)
DevTools
Inspector
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
when we are using the nodePicker with a remote nodeFront, and selecting it, we get the following error:
console.error: "Error while calling actor 'pagestyle's method 'getLayout'" "node is null"
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Attachment #9090693 -
Attachment description: Bug 1579053 - use relative nodeFront's target in pageStyles; r=pbro → Bug 1579053 - use relative nodeFront's target in pageStyles; r=gl
Updated•5 years ago
|
Assignee: nobody → ystartsev
Status: NEW → ASSIGNED
Whiteboard: dt-fission
Comment 2•5 years ago
|
||
Note that such patch is about fixing the box model.
Which is part of the layout view and bug 1568857.
Also note the existence of bug 1568126 which aims to track wide refactorings focusing on one pattern across the codebase.
And as Gabriel says on phabricator, we should sync up against bug 1568840 as I memoize the page style actor.
Updated•5 years ago
|
Attachment #9090693 -
Attachment description: Bug 1579053 - use relative nodeFront's target in pageStyles; r=gl → Bug 1579053 - use relative nodeFront's target in pageStyles; r=pbro
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b465f93bbfb use relative nodeFront's target in pageStyles; r=gl
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•4 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•