Thunderbird's about:profiles - unfitting FF button caption "Launch profile in new browser"
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(thunderbird_esr68? affected)
People
(Reporter: anjeyelf, Assigned: mkmelin)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
3.41 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Steps to reproduce:
'Help' > 'Troubleshooting Information'
'Troubleshooting information' opens in a new tab with focus
click on 'about:profiles'
Actual results:
'about:profiles' appeared in a tab.
But it uses the same tab that had 'Troubleshooting information' in it - it immediately closes 'Troubleshooting Information' which I then have to open again.
It also has a button saying 'Launch profile in a new browser' which is again confusing because Thunderbird does not use a browser.
Expected results:
'Troubleshooting Information' tab should not close.
'about:profiles' should open in a new tab and get focus.
Button 'Launch profile in a new browser' needs to worded accurately and not in a way to cause confusion - perhaps this is an unedited copy of what you may see in a 'Firefox' - about:profiles ?
Comment 1•5 years ago
|
||
Interesting.
Richard, can we override that string?
There's a bug in the system that requests making those about:* pages "navigable", that is, to add a "Back" function somehow. Right now, it's a pain :-( - See bug 1577823.
Let's fix the string here and add navigation over in the other bug.
Comment 2•5 years ago
|
||
This would need that we inject code to exchange the label. Would this be worth for a relatively seldom used page?
In Thunderbird, this page is going to be used a lot more due to significant changes. Now, new profiles are auto created and 'profiles.ini' does not necessarilly point the profile used by the user, which is especially confusing for those who have only ever used one profile and have just either installed version 68 and/or moved from one computer to another. So saying to open in a new browser instead of a new window is incorrect. People do not need incorrect labelling - it does not help, so yes it needs changing.
Comment 6•5 years ago
|
||
This issue goes to
a) credibility - when support tells someone to use this, in a problem situation that the user is already very unhappy about, and they see the product talking about a browser, users are not impressed - we look like fools.
b) as anje points out, with version 68 we increasingly need to point users to this for 64bit and other problems
For starters can we at least please get this fixed in current nightlies and beta?
Comment 7•5 years ago
|
||
This needs a injection in aboutProfiles.xhtml like we do for aboutAddons.html. This needs someone that knows JS better than me.
Assignee | ||
Comment 8•5 years ago
|
||
re : saying to open in a new browser instead of a new window is incorrect. People do not need incorrect labelling
Five months have now passed and there has been a few updates since.
Changing the words on a button cannot be that difficult. It is not changing any function of that button.
Maybe it has been changed in a beta and I'm not aware of it.
But I'm still having to apologies in support forums for the incorrect information as developers did not check it before releasing.
Can somone please confirm this small change has been done.
Assignee | ||
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9126960 [details] [diff] [review] bug1579725_launch_in_new.patch Thanks.
Assignee | ||
Comment 12•4 years ago
|
||
Successful try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=238ec2763cfc09e392bc86308d89ee43235d0c63&selectedJob=289266260
Comment 13•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3b6df2137d8f
about:profiles - Change "Launch profile in new browser" to "Launch profile" for Thunderbird. r=Paenglab DONTBUILD
Comment 14•3 years ago
|
||
Still reverts to the Firefox label after creating a new profile - bug 1689808.
Reporter | ||
Comment 15•3 years ago
|
||
(In reply to Thomas D. (:thomas8) from comment #14)
Still reverts to the Firefox label after creating a new profile - bug 1689808.
Agree. Tested in version 78.7.0 win64
Description
•