Closed
Bug 157979
Opened 23 years ago
Closed 22 years ago
Need seperate header for printing
Categories
(MailNews Core :: Printing, defect)
MailNews Core
Printing
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3alpha
People
(Reporter: yinglinxia, Assigned: nhottanscp)
References
(Depends on 1 open bug)
Details
(Keywords: l12y, Whiteboard: [ish1+][fixedish1])
Attachments
(1 file, 1 obsolete file)
6.30 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Currently the mail printing header is sharing same strings with mail
forward-as-attachment, in file mimeheader.properties. We need to seperate them,
cause for localization, we need to keep the forward header in English, but
localize the print header.
Assignee | ||
Comment 1•23 years ago
|
||
This is mail specific.
Assignee: rods → nhotta
Product: Browser → MailNews
Assignee | ||
Updated•23 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Updated•23 years ago
|
QA Contact: sujay → marina
Reporter | ||
Comment 2•23 years ago
|
||
This problem is found in bugscape bug 15671:
With the current Ja build, when a mail is printed out, the header lables, like
Subject: To: and etc. are still in English.
Please refer the following fixed i18n bug:
http://bugzilla.mozilla.org/show_bug.cgi?id=86980
and bug for l10n notes:
http://bugzilla.mozilla.org/show_bug.cgi?id=125446,
But please make sure the fix for this bug doesn't introduce regressions to bug
14230
------- Additional Comment #4 From rchen@netscape.com 2002-07-17 10:49 -------
According to nhotta, we won't localized the header lables, like
Subject: To: and etc. They should be in English.
------- Additional Comment #5 From Naoki Hotta 2002-07-17 11:10 -------
That is true for message compose/send (for JA build). For message view/print,
we
can localize them. I think the current problem is that the strings are shared
for view and compose.
------- Additional Comment #6 From Ying-Lin Xia 2002-07-17 13:48 -------
Right, I just made a test. The strings in file mimeheader.properties are shared
by both print and forward-as-attachment. Which means we can not translate it
now.
Assignee | ||
Comment 3•23 years ago
|
||
There is another file called "mime.properties" which also has "To", "From", etc.
Target Milestone: --- → mozilla1.2alpha
Updated•22 years ago
|
Whiteboard: [ish] → [ish1+]
Assignee | ||
Comment 4•22 years ago
|
||
I think I can change nsMimeBaseEmitter::MimeGetStringByName to get the string
differently based on 'mFormat' value. We want to avoid the localized strings to
be quoted and sent out (e.g. to the receiver who cannot handle the localized
strings).
The function currently uses mimeheader.properties. I can change it to use
mime.properties for quoting if we are sure that is not localized.
Basically, either mimeheader.properties or mime.properties has to stay unlocalized.
Assignee | ||
Comment 5•22 years ago
|
||
Comment 6•22 years ago
|
||
Comment on attachment 104195 [details] [diff] [review]
Use tranlated strings for headers if not quoting.
R=ducarroz
Attachment #104195 -
Flags: review+
Comment 7•22 years ago
|
||
I think nsCRT::strcmp is deprecated, though it does check for null args, so if
the strings might be null, you could still use it, I guess.
doesn't this leak val? should we use nsXPIDLString?
+ PRUnichar *val = nsnull;
+
+ res = m_stringBundle->GetStringFromID(aID, &val);
+
+ if (NS_FAILED(res))
+ return nsnull;
+
+ return ToNewUTF8String(nsAutoString(val));
+ }
Assignee | ||
Comment 8•22 years ago
|
||
Attachment #104195 -
Attachment is obsolete: true
Comment 9•22 years ago
|
||
Comment on attachment 104207 [details] [diff] [review]
Changed to use strcmp, fixed the leaks.
sr=bienvenu
Attachment #104207 -
Flags: superreview+
Assignee | ||
Updated•22 years ago
|
Whiteboard: [ish1+] → [ish1+][fixedish1]
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → mozilla1.3alpha
Assignee | ||
Comment 10•22 years ago
|
||
checked in to the trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•