Fix getSymbolTable code for popup to be consistent
Categories
(DevTools :: Performance Tools (Profiler/Timeline), task, P2)
Tracking
(firefox71 fixed)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently the popup is using the DevTools getSymbolTable code rather than the popup code WHEN CLICKING THE UI. The shortcuts use a different codepath, and use the frame scripts. This means that when clicking on the UI the profile will take longer to capture, as it will not be gzipped in an ArrayBuffer.
In addition, the getSymbolTable code in DevTools is using browser code in the client code.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
The popup's shortcuts use a different codepath than the popup's buttons.
When using the buttons, the profile was not being captured as a gzipped
profile, and it was using the DevTools' mechanism for getting the symbol
tables. This patch makes the getSymbolTables mechanism configuring in the
recording panel's client.
In addition, browser code made its way into the client. This patch moves
the browser code to all be in browser.js to match the original code
organization for the panel, which was trying to keep browser APIs
out of the React components and Redux store.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5a3661caf52f Factor out the getSymbolsTable browser code from client code; r=julienw
Pushed by dvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd4cb3bbf07c Factor out the getSymbolsTable browser code from client code; r=julienw
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•