1587135 - Megabar results are behind web content on Windows 7 / classic

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[trinywiky]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

This behaviour started a couple of days ago with one of the Nightly updates. I tried using a clean profile and using the dev-profile; running in safe mode, and still got the same behaviour.

I am running Firefox Nightly on a Win 7 x64. No add-ons installed.

Actual results:

When I click on the navigation bar (and also when starting the browser, since the navigation bar is selected), the field expands in all diretions. Then, when I start typing, the URL-suggestions appear, but I cannot see them. Only the top half of the first suggestion. Although it is still possible to go through the suggestions by using the arrow keys.
When I use a navigation bar with the separate search field, only the navigation bar behaves this way. The search field works fine.

Expected results:

The navigation bar should not change its size in all directions. Merely when the URL suggestions start to appear, it should be enlarged at the bottom showing all suggestions.

Comment 1

[trinywiky]

This behaviour does not happen in fullscreen mode. The navigation bar still enlarges its size, but the suggestions are not cut off.

Comment 2

[trinywiky]

Attachment: Screenshot.png

Comment 3

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0
20191008093420

The size increase is intentional behavior introduced in bug 1561531.

I can't reproduce the suggestions bug. It may be specific to the Windows Classic theme or Windows 7.

Comment 4

[trinywiky]

I have tried it on a Linux Mint 18.1 Cinnamon x64 and could not reproduce it either.

Comment 5

[Marco Bonardo [:mak]]

please attach a log from about:support

Comment 6

[trinywiky]

Attachment: Log.json

Comment 7

[trinywiky]

(In reply to Marco Bonardo [::mak] from comment #5)

please attach a log from about:support

Is this the log that you mean?

Comment 8

[trinywiky]

Attachment: Log_2.json

I have tested it with the Win 7 Aero design and this bug does not happen. So it might be restricted only to the classic theme.

Comment 9

[trinywiky]

See also: bug 1586457

Comment 11

[Dão Gottwald [:dao]]

Attachment: Bug 1587135 - Replace box-shadow on top of the classic title bar with a simpler gradient so we can remove the gross hacks to make it work.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eed9c4167e5
Replace box-shadow on top of the classic title bar with a simpler gradient so we can remove the gross hacks to make it work. r=Gijs

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7eed9c4167e5

Comment 16

[Tim Nguyen :ntim]

Does this affect non-megabar as well ? It might be nice to uplift if it does.

Comment 17

[Dão Gottwald [:dao]]

I checked this when investigating this bug and non-megabar doesn't seem to be affected, I'm guessing because it uses position:fixed.

Comment 18

[trinywiky]

(In reply to Tim Nguyen :ntim from comment #16)

Does this affect non-megabar as well ? It might be nice to uplift if it does.

The non-megabar is working fine for me. Also after the change.

(And the megabar now too. Thank you Dão)