Closed Bug 978752 Opened 7 years ago Closed 7 years ago

Tab strip gradient is broken in customization mode on Windows XP in classic mode

Categories

(Firefox :: Toolbars and Customization, defect)

30 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 30
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: phlsa, Assigned: Gijs)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [Australis:P3])

Attachments

(3 files, 2 obsolete files)

Attached image Glitch in tab strip (obsolete) —
When using the classic theme on Windows XP, the gradient of the tab strip is broken in customization mode.

The gradient we are using to overlay the title bar should extend all the way to the edges of the window, so that the »native« XP gradient isn't visible.
Gijs and I discussed that if we can't find a better solution, we can always negative margin the pseudoelement into submission.
Attached image POC Screenshot
I think we should switch from the linear-gradient and instead re-purpose the glass fog.

This will give it a softer look and avoid dirty grey/black caused by transitioning to transparent. Also will fix this bug with the hard edge in Customize.

Here is what I had to get the look in the screenshot:

#TabsToolbar:not(:-moz-lwtheme)::after {
  /* Because we use placeholders for window controls etc. in the tabstrip,
   * and position those with ordinal attributes, and because our layout code
   * expects :before/:after nodes to come first/last in the frame list,
   * we have to reorder this element to come last, hence the
   * ordinal group value (see bug 853415). */
  -moz-box-ordinal-group: 1001;
  box-shadow: 0 0 50px 8px ActiveCaption;
  content: "";
  display: -moz-box;
  height: 0;
  margin: 0 50px; /* (30px + 30px) from box-shadow */
  position: absolute;
  pointer-events: none;
  top: 100%;
  width: -moz-available;
  z-index: 0;
}
shorlander++ - this is way, way, wayyyyy better.
Assignee: mnoorenberghe → MattN+bmo
Duplicate of this bug: 879593
Duplicate of this bug: 907336
Stealing per discussion with Matt last week.
Assignee: MattN+bmo → gijskruitbosch+bugs
Status: NEW → ASSIGNED
So the annoying thing here is that we have to z-index all the things in the tabstoolbar apart from the ::after element in order to have them appear on top of the box shadow. That then causes other bugs (such as the tab overflow separator overlapping with the navbar). :-(
I basically took Stephen's patch and used his rules only for win classic. I then removed the style for fullscreen mode (where we have a grey background in the tabstoolbar so it doesn't work to add a blue fade), added styling for .toolbarbutton-1 so we don't break add-ons, and updated some comments. I left out the margin-top adjustment, which seems to be unrelated. The original patch was here: http://cl.ly/code/2o1u1U042a14 .
Attachment #8391151 - Flags: review?(mconley)
Comment on attachment 8391151 [details] [diff] [review]
fix Windows Classic gradient for Australis,

This looks really good! We need to disable the fog for classic when tabs are not in the titlebar though.
Attachment #8391151 - Flags: review?(mconley) → feedback+
Comment on attachment 8391151 [details] [diff] [review]
fix Windows Classic gradient for Australis,

Review of attachment 8391151 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/windows/browser.css
@@ +143,5 @@
> +    box-shadow: 0 0 50px 8px ActiveCaption;
> +    content: "";
> +    display: -moz-box;
> +    height: 0;
> +    margin: 0 50px; /* (30px + 30px) from box-shadow */

Also, 30px + 30px != 50px...
Now with [tabsintitlebar], but with a :not([selected=true] for the tabbrowser tab so that it continues getting a still higher z-index (otherwise the top of the navbar/bottom of the tabbar overlaps it)
Attachment #8391235 - Flags: review?(mconley)
Attachment #8391151 - Attachment is obsolete: true
Comment on attachment 8391235 [details] [diff] [review]
fix Windows Classic gradient for Australis,

Review of attachment 8391235 [details] [diff] [review]:
-----------------------------------------------------------------

Let's roll with this. \o/ Thanks Gijs!
Attachment #8391235 - Flags: review?(mconley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/a7e1aeb46c79
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a7e1aeb46c79
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
Comment on attachment 8391235 [details] [diff] [review]
fix Windows Classic gradient for Australis,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: Tabs in titlebar looks bad on Windows classic themes
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, might affect add-ons (but we did our best not to...)
String or IDL/UUID changes made by this patch: none
Attachment #8391235 - Flags: approval-mozilla-aurora?
Attachment #8391235 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 986515
Depends on: 986920
Depends on: 990099
QA Whiteboard: [qa-]
See Also: → 1587135
You need to log in before you can comment on or make changes to this bug.