1594299 - Disable LSNG in 71

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Jan Varga [:janv]]

We can't ship it on Release until storage initialization failures are addressed.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Jan, can you prepare the uplift for tomorrow please? Thanks

Comment 2

[Jan Varga [:janv]]

Yes, will do.

Comment 3

[Jan Varga [:janv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cd867f64764cc0adc68b0156051506cddf10c4f

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1594299 - Disable LSNG in 71; r=asuth

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Can I get the uplift request now? I plan to go to build beta 10 in a few hours. Thanks.

Comment 6

[Jan Varga [:janv]]

Comment on attachment 9108406 [details]
Bug 1594299 - Disable LSNG in 71; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: If LSNG is enabled, LocalStorage depends on QuotaManager storage which is currently broken for some users. We don't want to ship LSNG until the issue is fixed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch just disables LSNG, so the old implementation of LocalStorage will be used in FF 71. We fully support downgrading of LocalStorage data, so if some users already tried a beta build, they should be safe. We disabled LSNG in previous beta cycles and there were no problems reported after the switch.
• String changes made/needed: None

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9108406 [details]
Bug 1594299 - Disable LSNG in 71; r=asuth

Uplift approved for 71 beta 10, thanks.

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce4294110628

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.

Comment 10

[Julien Cristau [:jcristau]]

Is LSNG supposed to ship in 72? I didn't think so, but it hasn't been disabled as far as I can tell. Can we please land a change on trunk to make it nightly-only or early-beta-only, until there's a shipping forecast?

Comment 11

[Jan Varga [:janv]]

We have a patch for disabling it, :asuth will review it today, bug 1606781. Regarding making it nightly-only or early-beta-only, well, that would be a step backwards because we know that LSNG works quite well on Nightly and Beta, but if there are any new issues (especially on Beta) we want to let users to report it. We also have a shipping forecast, FF 74 or 75.

Comment 12

[Julien Cristau [:jcristau]]

Shipping by accident would be even worse IMO... Not to mention we're no longer exposing the old storage code path to our pre-release users, so any regression there would go unnoticed.

Comment 13

[Jan Varga [:janv]]

Well, a compromise is to disable it in beta 10 (like we did for 71). Everything would be automatic, if we had a tag/define for it.
For example, we now have EARLY_BETA_OR_EARLIER, but maybe it would be useful to have LATE_BETA_OR_EARLIER as well

Comment 14

[Jens Stutte [:jstutte]]

Same as https://bugzilla.mozilla.org/show_bug.cgi?id=1570644#c18.