1596656 - Move OBJCOPY and STRIP detection to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Makoto Kato [:m_kato]]

Since we use AC_CHECK_PROG to detect OBJCOPY and STRIP (for cross build and linux target), it doesn't work on Windows host. (Path has space etc)

Of course, when we use OBJCOPY=xxx in .mozconfig, it works well.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1596656 - Move OBJCOPY and STRIP detection to moz.configure.

clang-cl sets PKG_SKIP_STRIP=1, so STRIP='echo not_strip' may be unnecessary.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1596656 - Move OBJCOPY to python configure.

As a bonus, we also check and prefer llvm-objcopy when it's suitable.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1596656 - Move STRIP to python configure.

As a bonus, we also check and prefer llvm-strip when it's suitable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c8f3c0aac51
Move OBJCOPY to python configure. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/da8f11880896
Move STRIP to python configure. r=firefox-build-system-reviewers,andi

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6c8f3c0aac51
https://hg.mozilla.org/mozilla-central/rev/da8f11880896

Comment 6

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1596656) for causing jittest failures on 1659595.js.
Backout link
Push with failures
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5cca3717e5a
Move OBJCOPY to python configure. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/0252bbc54dd1
Move STRIP to python configure. r=firefox-build-system-reviewers,andi

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5cca3717e5a
Move OBJCOPY to python configure. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/0252bbc54dd1
Move STRIP to python configure. r=firefox-build-system-reviewers,andi

== Change summary for alert #33094 (as of Wed, 26 Jan 2022 14:42:44 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	installer size	osx-aarch64-shippable	aarch64 nightly	72,384,139.25 -> 73,665,793.83

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33094

Comment 9

[Mike Hommey [:glandium]]

(In reply to Alexandru Ionescu (needinfo me) [:alexandrui] from comment #8)

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33094

This link sends to an alert on mozilla-beta...

Comment 10

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Marked it as obsolete, thanks.

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b5cca3717e5a
https://hg.mozilla.org/mozilla-central/rev/0252bbc54dd1