1598079 - Turn abuseReport.openDialog on by default on all channels

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

In Bug 1580554 (part of the changes needed for Bug 1580561) we also added a separate "extensions.abuseReport.openDialog" preference which makes the abuse report panel triggered from about:addons and from the browserAction context menu to be opened in a dialog window (instead of being embedded inside the about:addons tab) as it happens when the same report panel is being triggered from AMO using the mozAddonManager.reportAbuse API method.

We would like to make this the default behavior because it makes it consistent with the behavior of the mozAddonManager.reportAbuse API, and it would allow us to remove the subframe from inside about:addons and avoid the workarounds needed to make the keyboard navigation to work as expected when the focus in moved back and forth the "fake" modal panel using the keyboard.

This isn't necessary to allow AMO to hand-off the report submissions initiated from the AMO website, and so I would leave it to ride the train (instead of requesting an uplift to 71 Beta as I'm going to do for Bug 1598062).

Also, I just noticed that to be able to turn it on by default there is at least one additional test that needs to be fixed accordingly:

• browser/components/extensions/test/browser/browser_ext_browserAction_contextMenu.js

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1598079 - Turn abuseReport.openDialog on by default on all channels. r?mstriemer!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=480dc1bf7355128ed28f2f2f818457535b020ca7

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Jorge,
would you mind to confirm that it sounds ok from a product perspective to not uplift this feature to 71 beta and just let it ride the train? ([1])

[1]: because AMO doesn't need the "extensions.abuseReport.openDialog" pref to be set to true to be able to hand-off the report to Firefox. As I mentioned in comment 0 Bug 1598062 is the only one that we would really like to get into 71 beta.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Yes, that sounds good to me.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Pascal,
I wanted to double-check with you if we can land this patch today:

the behavior locked behind this pref has been QA verified while it was disabled by default in 71 Beta, I intended to land this patch to enable it by default on Firefox 72 and let it right the train, but I had to deal with a test that was going to fail once the extension.abuseReport.openDialog pref was set to true by default and so we weren't able to push it to autoland on Friday.

If we prefer to defer it to Firefox 73, it is fine, but I wanted to explicitly check with you if we can still proceed as originally planned.

Comment 6

[Pascal Chevrel:pascalc]

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #5)

Hi Pascal,
I wanted to double-check with you if we can land this patch today:

the behavior locked behind this pref has been QA verified while it was disabled by default in 71 Beta, I intended to land this patch to enable it by default on Firefox 72 and let it right the train, but I had to deal with a test that was going to fail once the extension.abuseReport.openDialog pref was set to true by default and so we weren't able to push it to autoland on Friday.

If we prefer to defer it to Firefox 73, it is fine, but I wanted to explicitly check with you if we can still proceed as originally planned.

I'll defer to Julien as he is the release owner for 72 and my brains today are focused on 71 RC :)

Comment 7

[Julien Cristau [:jcristau]]

I'd prefer to defer the pref change to Monday. We can consider an uplift later next week though, if need be?

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Julien Cristau [:jcristau] from comment #7)

I'd prefer to defer the pref change to Monday.

Thanks for the feedback Julien, I'm ok to land this "pref toggling" patch on Firefox 73, let it bake on Nightly a bit and then re-evaluate if we want to uplift it to 72 or just let it ride 73 train.

We can consider an uplift later next week though, if need be?

As I mentioned in my previous comment, it is part of work done and landed in 71 Nightly and QA verified explicitly on 71 Beta, but we don't necessarily need to enable this in 72 because no other work is currently blocked on it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45ad5d36d924
Turn abuseReport.openDialog on by default on all channels. r=mstriemer

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/45ad5d36d924

Comment 11

[Victor Carciu]

Verified as fixed on FF73 73.0a1 (2019-12-05).

I will attach a postfix screeenshot.

Comment 12

[Victor Carciu]

Attachment: Postfix Screenshot