Closed Bug 1598660 Opened 6 years ago Closed 6 years ago

Please install XQuartz on the mac workers

Categories

(Infrastructure & Operations :: RelOps: General, task)

Unspecified
macOS
task
Not set
critical

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mbrandt, Unassigned)

References

Details

In support of the Firefox Iris test automation work, we need xquartz installed on the macworkers.

https://www.xquartz.org/

Looking at homebrew's formula, it is a pkg install without special linking or configuration added: https://formulae.brew.sh/cask/xquartz#default
https://github.com/Homebrew/homebrew-cask/blob/master/Casks/xquartz.rb

The dmg is about 75.9mb.

Matt, do you know if xquartz can be executed on demand? Since it is small, could it be put into tooltool and downloaded(on first load, tooltool caches locally)+executed during the task?

Flags: needinfo?(mbrandt)

That's a good question, I'm not sure. Let me query my teammates on this.

(In reply to Dave House [:dhouse] from comment #2)

Matt, do you know if xquartz can be executed on demand? Since it is small, could it be put into tooltool and downloaded(on first load, tooltool caches locally)+executed during the task?

Flags: needinfo?(mbrandt)

(In reply to Matt Brandt [:mbrandt] (he/him) from comment #3)

That's a good question, I'm not sure. Let me query my teammates on this.

(In reply to Dave House [:dhouse] from comment #2)

Matt, do you know if xquartz can be executed on demand? Since it is small, could it be put into tooltool and downloaded(on first load, tooltool caches locally)+executed during the task?

It looks like the only part of xquartz used in iris is "xset". Is that right? If so, we might replace it with something macos-native (probably requires sudo).
It also looks like xset is used only to check the keyboard state (https://github.com/mozilla/iris/blob/14b8b05a83345f7a0b79a7a53d2f010151383129/moziris/api/keyboard/keyboard_util.py#L69). In that case, we can know the mac minis do not have their caps-lock etc set. So maybe we could just turn off that part of Iris?

Could you check if we can turn off(code change to allow turning it off) that part of iris on the minis?

Flags: needinfo?(mbrandt)

(In reply to Dave House [:dhouse] from comment #5)

Could you check if we can turn off(code change to allow turning it off) that part of iris on the minis?

The ability to not use this was built into Iris when this check was implemented. Use the iris -n command line argument to skip the check of keyboard state.

Flags: needinfo?(mbrandt)

(In reply to Tracy Walker [:tracy] from comment #6)

(In reply to Dave House [:dhouse] from comment #5)

Could you check if we can turn off(code change to allow turning it off) that part of iris on the minis?

The ability to not use this was built into Iris when this check was implemented. Use the iris -n command line argument to skip the check of keyboard state.

Thanks Tracy! That sounds like xquartz is possibly not needed on the mac minis then to run iris.

Brilliant, thank you all for digging into this. I'll close out this bug as WONTFIX unless there's an objection

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.