Add support for `fix-stacks` and use it for DMD
Categories
(Toolkit :: Crash Reporting, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(5 files)
fix-stacks
is the new, fast, cross-platform stack fixer written in Rust.
![]() |
Assignee | |
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Moving component to Toolkit > Crash Reporting, if this is not the correct component, please adjust it.
![]() |
Assignee | |
Comment 3•5 years ago
|
||
It currently is missing some cross-compilation stuff and so actually builds a
Linux binary.
The commit also avoids the unintentional installation of the fix-stacks.d
file, by introducing the EXE
variable.
![]() |
Assignee | |
Comment 4•5 years ago
|
||
Depends on D64528
Updated•5 years ago
|
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42d63c42c6a2 Fix up `fix-stacks` toolchain on Mac. r=erahm
Comment 6•5 years ago
|
||
bugherder |
![]() |
Assignee | |
Updated•5 years ago
|
Updated•5 years ago
|
![]() |
Assignee | |
Comment 7•5 years ago
|
||
The new version has two improvements.
- It has slightly changed output in some cases -- more similar to the existing
stack fixers -- which avoids the need to change the DMD tests. - It fixes some erroneous double-JSON-escaping that caused excess backslashes
in Windows paths.
![]() |
Assignee | |
Comment 8•5 years ago
|
||
Depends on D65055
Updated•5 years ago
|
![]() |
Assignee | |
Comment 9•5 years ago
•
|
||
This try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=620a3fc83100215baa2eba5125388d09300be236
I think this is ready to land.
![]() |
Assignee | |
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4fa2ef53b3a8 Update the `fix-stacks` version. r=glandium https://hg.mozilla.org/integration/autoland/rev/7ffb4f86d024 Build `fix-stacks` as 32-bit on Windows, cross-compiling from Linux. r=glandium
Comment 11•5 years ago
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1083f8fd076a Install `fix-stacks` in `mach bootstrap`. r=glandium
![]() |
Assignee | |
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83f7d764a8ab Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto
Comment 13•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4fa2ef53b3a8
https://hg.mozilla.org/mozilla-central/rev/7ffb4f86d024
https://hg.mozilla.org/mozilla-central/rev/1083f8fd076a
https://hg.mozilla.org/mozilla-central/rev/83f7d764a8ab
![]() |
Assignee | |
Updated•5 years ago
|
Description
•