1604095 - Add support for `fix-stacks` and use it for DMD

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Nicholas Nethercote [:njn] (On Long Service Leave)]

fix-stacks is the new, fast, cross-platform stack fixer written in Rust.

Comment 1

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1604095 - Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto,glandium

Comment 2

[Daniel Kolsis]

Moving component to Toolkit > Crash Reporting, if this is not the correct component, please adjust it.

Comment 3

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1604095 - Fix up `fix-stacks` toolchain on Mac. r=erahm

It currently is missing some cross-compilation stuff and so actually builds a
Linux binary.

The commit also avoids the unintentional installation of the fix-stacks.d
file, by introducing the EXE variable.

Comment 4

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1604095 - Install `fix-stacks` in `mach bootstrap`. r=glandium

Depends on D64528

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d63c42c6a2
Fix up `fix-stacks` toolchain on Mac. r=erahm

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/42d63c42c6a2

Comment 7

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1604095 - Update the `fix-stacks` version. r=glandium

The new version has two improvements.

• It has slightly changed output in some cases -- more similar to the existing
  stack fixers -- which avoids the need to change the DMD tests.
• It fixes some erroneous double-JSON-escaping that caused excess backslashes
  in Windows paths.

Comment 8

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Bug 1604095 - Build `fix-stacks` as 32-bit on Windows, cross-compiling from Linux. r=glandium

Depends on D65055

Comment 9

[Nicholas Nethercote [:njn] (On Long Service Leave)]

This try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=620a3fc83100215baa2eba5125388d09300be236

I think this is ready to land.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa2ef53b3a8
Update the `fix-stacks` version. r=glandium
https://hg.mozilla.org/integration/autoland/rev/7ffb4f86d024
Build `fix-stacks` as 32-bit on Windows, cross-compiling from Linux. r=glandium

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1083f8fd076a
Install `fix-stacks` in `mach bootstrap`. r=glandium

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83f7d764a8ab
Add `fix_stacks.py`, which uses `fix-stacks`, and use it in DMD. r=gsvelto

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4fa2ef53b3a8
https://hg.mozilla.org/mozilla-central/rev/7ffb4f86d024
https://hg.mozilla.org/mozilla-central/rev/1083f8fd076a
https://hg.mozilla.org/mozilla-central/rev/83f7d764a8ab