Closed Bug 1774362 Opened 3 years ago Closed 3 years ago

Changes needed for bug 1607331 - Reject global this usage in JSM

Categories

(Thunderbird :: Upstream Synchronization, task)

Product:
Thunderbird
Component:
Upstream Synchronization
Type:
task

Tracking

(thunderbird_esr102 unaffected, thunderbird102 unaffected)

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird102 --- unaffected

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: leave-open)

Attachments

(2 files, 4 obsolete files)

Bug 1774362 - Changes needed for bug 1607331 - Reject global this usage in JSM. calendar/ part. r=freaktechnik
48 bytes, text/x-phabricator-request
Details | Review
Bug 1774362 - Changes needed for bug 1607331 - Reject global this usage in JSM. mail/mailnews/calendar/chat r=freaktechnik
48 bytes, text/x-phabricator-request
Details | Review

We have a bunch of ES lint failures after bug 1607331. Looks like I overlooked ChromeUtils.defineModuleGetter in earlier fixes.

Status: NEW → ASSIGNED
status-thunderbird102: --- → unaffected
Keywords: leave-open
Target Milestone: --- → 103 Branch
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/192df5f7a660 Changes needed for bug 1607331 - Reject global this usage in JSM. calendar/ part. r=freaktechnik

Internally its using lazy and is loaded early.

Depends on D149384

Attachment #9281414 - Attachment description: Bug 1774362 - Make MailServices.jsm non lazy. r=freaktechnik → Bug 1774362 - Changes needed for bug 1607331 - Reject global this usage in JSM. mail/mailnews/calendar/chat r=freaktechnik
Attachment #9281414 - Attachment is obsolete: true
Attachment #9281407 - Attachment is obsolete: true
Attachment #9281406 - Attachment is obsolete: true
Attachment #9281414 - Attachment is obsolete: false
Attachment #9281405 - Attachment is obsolete: true
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/5833586a5bd0 Changes needed for bug 1607331 - Reject global this usage in JSM. mail/mailnews/calendar/chat r=freaktechnik

PCOMUtils is again defined inside the contentAreaClick.js script, so triggers redeclaration error.

Keywords: checkin-needed-tb

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6bb172bf71a7
follow-up - Revert a change from var to const that broke things. rs=bustage-fix

Keywords: checkin-needed-tb
Attachment #9281481 - Attachment is obsolete: true
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/d0a3cfd59b58 follow-up - additional fix after bug 1773747. rs=eslint
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-thunderbird_esr102: --- → unaffected
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: