1612711 - (tsan-tests-basic) Enable XPCShell tests and Mochitests as Tier1 tests on Linux64 TSan

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Christian Holler (:decoder)]

In order to avoid more races being added to our codebase, we need to enable some tests on TSan (Linux64 only). I've been working on Mochitests and XPCShell tests and they are almost green (and in the process, quite a few valuable bugs were discovered).

Initially, these should be Tier1 until everything has settled a bit, but then we should be able to downgrade them to Tier1.5 (every 10-th push on autoland) to save some resources, if they regress infrequently enough.

Comment 1

[Christian Holler (:decoder)]

Attachment: Bug 1612711 - Enable Mochitests and XPCShell tests for TSan. r?froydnj

Comment 2

[Christian Holler (:decoder)]

Attachment: Bug 1612711 - Update TSan suppressions for Mochitests/XPCShell tests. r?froydnj

Depends on D62628

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b633de1ffd9
Enable Mochitests and XPCShell tests for TSan. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/6555c6ff928a
Update TSan suppressions for Mochitests/XPCShell tests. r=froydnj

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0b633de1ffd9
https://hg.mozilla.org/mozilla-central/rev/6555c6ff928a

Comment 5

[Christian Holler (:decoder)]

I'm using leave-open here because the tests have landed, but they aren't marked Tier1 yet. I have to figure out where exactly that missing switch is.

Comment 6

[Christian Holler (:decoder)]

Attachment: Bug 1612711 - Switch TSan tests to Tier1. r?froydnj

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcad83ac1ad6
Switch TSan tests to Tier1. r=froydnj

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dcad83ac1ad6

Comment 9

[Christian Holler (:decoder)]

Clearing the stray leave-open, this has been fixed by comment 7.