1614496 - Implement WebXR Core Module DOM interfaces

Status: RESOLVED FIXED

(Core :: WebVR, task, P2)

Description

[:kip (Kearwood Gilbert)]

This bug tracks the landing of the DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1614496 - Implement WebXR Core Module DOM Interfaces

Implement DOM interfaces for the WebXR Core Module. Additional work to implement the WebXR Core Module are marked with TODO (Bug #) comments within the patch and must be landed before enabling the dom.vr.webxr.enabled flag.

Comment 2

[:kip (Kearwood Gilbert)]

Try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e3202a2fb696d5fb174bbf9705c6238d33a83ec

Comment 3

[:kip (Kearwood Gilbert)]

Updated try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=921ff6f7b99b5724ba5ccdead1ec7c063ff720b5

Comment 4

[:kip (Kearwood Gilbert)]

Addressed all review feedback. Updated try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d0cc22b4841d6884a845d170286056261f881d8

Comment 5

[:kip (Kearwood Gilbert)]

Try run looks good.

Comment 8

[:kip (Kearwood Gilbert)]

I have filed a spec issue and PR to correct the WebIDL for XRReferenceSpaceEvent that was preventing it from being generated with codegen.py:

https://github.com/immersive-web/webxr/issues/981

Comment 9

[:kip (Kearwood Gilbert)]

Updated try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b0c774f6ec125c9205c06b063b47a9e1898da7f

Comment 10

[:kip (Kearwood Gilbert)]

Applied feedback from @peterv

Comment 11

[:kip (Kearwood Gilbert)]

Applied feedback from @jgilbert and fixed static analysis error found in last try run.

Comment 12

[:kip (Kearwood Gilbert)]

Updated try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=718a1e05f0709126f2ad5f75c5496e18f106a03f

Comment 13

[:kip (Kearwood Gilbert)]

Try push looks good. I'll land after the code freeze is lifted.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3426e213b24
Implement WebXR Core Module DOM Interfaces r=jgilbert,daoshengmu,webidl,smaug,baku,imanol

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a3426e213b24